-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Load selectable checks for a host #1600
Conversation
4ebcc91
to
217f7d9
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey man good work!
Maybe we can use One component for HostInfoBox and ClusterInfoBox in the future as they are similar and we could spare some css fights.
Besides this i left just some small comments but nothing strong minded --> LGTM
55d32e8
to
ee223b5
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It looks good in general.
I would ask @jagabomb to visit the design of the check selection view.
Two side notes:
- I would personally like to have a storybook story for the host settings, as it looks pretty easy to have
- Having the
HostSettings
insideHostDetails
would be more consistent, as we do this way in the clusters details view. Anyway, I don't know if some work is in progress for this, as there are many leftovers from previousCheckSelection
refactor
Thanks @arbulu89 for the review.
answered inline in the comment
I see where this comes from. I did that in light of our ADR about the frontend, however I reckon we're still not in the position to adhere that one. I can move back the
So, well yes its a WIP and Jurgen would need to review more thoroughly as we get closer to his design, which we'd need to iterate over to get closer 😄 |
ee223b5
to
0366b16
Compare
0366b16
to
18fffb0
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you @nelsonkopliku ,
Some nitpicks. Feel free to ignore them XD
Ready to merge in any case
Description
First of a series of PRs that will bring checks to hosts.
The main thing that this change allows to do is to load the selectable checks for a specific host
You can browse to
/hosts/:hostID/settings
and see it loads the catalog for the host.If running it locally make sure to have at least one check in wanda with
env.target_type == "host"
in thewhen
condition, otherwise since there is no host checks currently available the page would be empty (story added)We need to iterate multiple times to get to the final state of the design, so what we're focusing on now is making it work, then make it beautiful. Otherwise the PRs would be huge.
Next: add state/saga for the host check selection and trigger the API call when clicking on Save Check Selection.
How was this tested?
Automated tests.