Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle linking to unregistered hosts #1560

Merged
merged 13 commits into from
Jul 17, 2023
Merged

Conversation

rtorrero
Copy link
Contributor

Captura desde 2023-06-21 09-50-03

Description

Check for unregistered hosts to avoid linking and show a warning

@rtorrero rtorrero force-pushed the remove-link-unregistered-hots branch from a3df8ec to 7b77fb3 Compare June 21, 2023 12:03
Copy link
Contributor

@arbulu89 arbulu89 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For the record, knowing that the PR is in draft.
This change will cause massive conflicts on main, as this file is even deleted.
I encourage to base this work on main branch.

Base automatically changed from deregistration to main June 29, 2023 16:21
@rtorrero rtorrero force-pushed the remove-link-unregistered-hots branch 3 times, most recently from 26ea678 to d44dd39 Compare July 3, 2023 14:11
Copy link
Contributor

@arbulu89 arbulu89 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@rtorrero I think we could put this logic in the already existing HostLink component, or create a new one, as we need to have this logic in the ascs/ers clusters as well.
What do you think?

@rtorrero rtorrero force-pushed the remove-link-unregistered-hots branch from 20e91cd to 5041a67 Compare July 10, 2023 12:03
@rtorrero
Copy link
Contributor Author

@rtorrero I think we could put this logic in the already existing HostLink component, or create a new one, as we need to have this logic in the ascs/ers clusters as well. What do you think?

I had this conversation a few weeks with @dottorblaster and we went for the current approach to avoid adding artifacts to places where HostLink might have been used in a different context.

But your point avoid avoiding duplicating the logic in the ascs/ers clusters is a valid concern. As you suggested in Slack, creating a separate ClusterNodeLink component seems the way to go.

@rtorrero rtorrero force-pushed the remove-link-unregistered-hots branch from b145b18 to f2a6a28 Compare July 11, 2023 15:45
@rtorrero rtorrero marked this pull request as ready for review July 11, 2023 15:47
@rtorrero rtorrero marked this pull request as draft July 11, 2023 16:23
@rtorrero rtorrero marked this pull request as ready for review July 12, 2023 06:34
Copy link
Contributor

@arbulu89 arbulu89 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good!
Some minor changes and we are ready to merge
@jagabomb could you have a look on how it looks?
Changes available in PR storybook. Stories AscsErsClusterDetails and HanaClusterDetails

...Single.args,
hosts: [buildHostsFromAscsErsClusterDetails(details).pop()],
},
render: (args) => (
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we need to at some point move this render to the main export default to avoid not needed repetition.
Could we do it in a next PR?
It would we as simple as moving this exact render up

assets/js/components/ClusterDetails/ClusterNodeLink.jsx Outdated Show resolved Hide resolved
Copy link
Contributor

@arbulu89 arbulu89 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Much better 😃
Feel free to merge once you have @jagabomb 's approval

Copy link
Member

@CDimonaco CDimonaco left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job LGTM when @jagabomb approves

@rtorrero rtorrero requested a review from jagabomb July 12, 2023 14:04
Copy link
Contributor

@jagabomb jagabomb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. I would like to also double check this with @abravosuse when he is back. But so far this solution makes sense to me.

@rtorrero rtorrero requested a review from abravosuse July 17, 2023 11:25
Copy link
Contributor

@abravosuse abravosuse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have reviewed AscsErsClusterDetails With Unregistered Host and HanaClusterDetails With Unregistered Host in the Storybook and they both look good to me.

@rtorrero rtorrero merged commit 35c42a5 into main Jul 17, 2023
16 checks passed
@rtorrero rtorrero deleted the remove-link-unregistered-hots branch July 17, 2023 15:12
@arbulu89 arbulu89 added the enhancement New feature or request label Aug 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Development

Successfully merging this pull request may close these issues.

6 participants