Fix application instance deletion after_update (#1616)

trento-project · Jul 11, 2023 · 74402c1 · 74402c1
1 parent 7a962ab
commit 74402c1
Show file tree

Hide file tree

Showing 4 changed files with 27 additions and 23 deletions.
diff --git a/lib/trento/application/projectors/database_projector.ex b/lib/trento/application/projectors/database_projector.ex
@@ -186,11 +186,12 @@ defmodule Trento.DatabaseProjector do
       sap_system_id: sap_system_id
     },
     fn multi ->
-      deregistered_instance = %DatabaseInstanceReadModel{
-        sap_system_id: sap_system_id,
-        instance_number: instance_number,
-        host_id: host_id
-      }
+      deregistered_instance =
+        Repo.get_by(DatabaseInstanceReadModel,
+          sap_system_id: sap_system_id,
+          instance_number: instance_number,
+          host_id: host_id
+        )
 
       Ecto.Multi.delete(multi, :database_instance, deregistered_instance)
     end
@@ -346,12 +347,12 @@ defmodule Trento.DatabaseProjector do
           sap_system_id: sap_system_id
         },
         _,
-        _
+        %{
+          database_instance: %DatabaseInstanceReadModel{
+            sid: sid
+          }
+        }
       ) do
-    %DatabaseReadModel{
-      sid: sid
-    } = Repo.get!(DatabaseReadModel, sap_system_id)
-
     TrentoWeb.Endpoint.broadcast(
       @databases_topic,
       "database_instance_deregistered",

diff --git a/lib/trento/application/projectors/sap_system_projector.ex b/lib/trento/application/projectors/sap_system_projector.ex
@@ -357,12 +357,10 @@ defmodule Trento.SapSystemProjector do
           sap_system_id: sap_system_id
         },
         _,
-        _
+        %{
+          application_instance: %ApplicationInstanceReadModel{sid: sid}
+        }
       ) do
-    %SapSystemReadModel{
-      sid: sid
-    } = Repo.get!(SapSystemReadModel, sap_system_id)
-
     TrentoWeb.Endpoint.broadcast(
       @sap_systems_topic,
       "application_instance_deregistered",

diff --git a/test/trento/application/projectors/database_projector_test.exs b/test/trento/application/projectors/database_projector_test.exs
@@ -270,11 +270,14 @@ defmodule Trento.DatabaseProjectorTest do
   test "should remove a database instance from the read model after a deregistration" do
     deregistered_at = DateTime.utc_now()
 
-    %{sid: sid} = insert(:database, id: sap_system_id = Faker.UUID.v4())
-    insert_list(4, :database_instance)
+    %{
+      sid: sid,
+      sap_system_id: sap_system_id,
+      instance_number: instance_number,
+      host_id: host_id
+    } = insert(:database_instance)
 
-    %{instance_number: instance_number, host_id: host_id} =
-      insert(:database_instance, sap_system_id: sap_system_id, sid: sid)
+    insert_list(4, :database_instance)
 
     event = %DatabaseInstanceDeregistered{
       instance_number: instance_number,

diff --git a/test/trento/application/projectors/sap_system_projector_test.exs b/test/trento/application/projectors/sap_system_projector_test.exs
@@ -279,10 +279,12 @@ defmodule Trento.SapSystemProjectorTest do
   test "should remove an application instance from the read model after a deregistration" do
     deregistered_at = DateTime.utc_now()
 
-    %{sid: sid} = insert(:sap_system, id: sap_system_id = Faker.UUID.v4())
-
-    %{instance_number: instance_number, host_id: host_id} =
-      insert(:application_instance, sap_system_id: sap_system_id, sid: sid)
+    %{
+      sid: sid,
+      sap_system_id: sap_system_id,
+      instance_number: instance_number,
+      host_id: host_id
+    } = insert(:application_instance)
 
     insert_list(4, :application_instance)