Discover host ip address netmasks #346
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
arbulu89
changed the title
arbulu89
force-pushed
the
discover-network-interfaces
branch
from
5f04ade
to
5ecd810
Compare
EMaksy
reviewed
Jul 18, 2024
| "10.1.1.6" | ||
| ], | ||
| "netmasks": [ | ||
| 24, |
There was a problem hiding this comment.
The only thing what concerns me is we must just think about using always the correct index in trento web for ip addresses and netmasks:)
There was a problem hiding this comment.
As the length of ip addresses and netmasks is always the same, you can use the standard zip and unzip functions to combine them pretty easily
There was a problem hiding this comment.
Oh, today I learned about lodash zipWith. Okay, this is cool!
Then never mind.
CDimonaco
approved these changes
Jul 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Discover host netmasks and send them in the
netmasksfield. Each value corresponds the value in the same position forip_addresses.I'm aware that this "position related" usage is not optimal, and actually, in the 1st commit I implemented a more complex struct to send complete network interfaces. But this makes compatibility between old web/new agent, new web/old agent more difficult, so I sticked to simplest solution.
If for some reason, in the future we need more information about network interfaces, I finally think that we will need something more complex implementation that eventually will require some upgrade in api versioning or even major version of agent/web.
How was this tested?
Partially tested...
We don't have any code testing host discoveries, and in fact, testing
networkrelated things is pretty difficult.Basically the serialization as json is the unique thing that it is tested.
In any case, the used functions are not changed, just the composed final code, so as everything was working now, i expect that it will continue working