Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Only run if slowzone data has been updated today #43

Merged
merged 4 commits into from
Mar 28, 2024

Conversation

devinmatte
Copy link
Member

Ensure your PR title follows the Conventional Commits spec

Motivation

Relies on https://github.com/transitmatters/slow-zones/pull/41

Changes

Exits if the slowzone data hasn't been updated yet today

Testing Instructions

@github-actions github-actions bot added the backend Change to backend code label Dec 19, 2023
slowzones.py Outdated Show resolved Hide resolved
@devinmatte
Copy link
Member Author

@mathcolo @nathan-weinberg Would love to get this back on the review block

@devinmatte devinmatte changed the title Only run if slowzone data has been updated today [feat] Only run if slowzone data has been updated today Mar 11, 2024
@devinmatte devinmatte changed the title [feat] Only run if slowzone data has been updated today feat: Only run if slowzone data has been updated today Mar 11, 2024
grouped_sz_today = generate_grouped_slow_zone_list(slow_zones.json(), date.today())
if date.fromisoformat(slow_zones.json()["updated_on"]) != date.today():
logging.error("Slow zone data was not updated yet today")
# exit if no issues

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

exit if issues? 😉

@devinmatte devinmatte merged commit 3f86672 into main Mar 28, 2024
4 of 7 checks passed
@devinmatte devinmatte deleted the handle-update-date branch March 28, 2024 23:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backend Change to backend code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants