feat: ✨ input validation using schema #1166
Conversation
mloiseleur
added
kind/enhancement
This comment was marked as resolved.
This comment was marked as resolved.
mloiseleur
force-pushed
the
feat/schema
branch
from
40917ff
to
ebe8f85
Compare
mloiseleur
added
status/2-needs-review
kind/proposal
|
@jnoordsij If you can take a look, it would be great 🙏 |
There was a problem hiding this comment.
Oooh I like this a lot, could be very useful to have for validation in IDEs to spot errors more easily. Great work!
Maybe we want to document this for contributors as well? Or even try to have some workflow setup to automatically update the generated schema file? Otherwise probably updating it somewhere in the release process similar to the changelog works fine as well, but still that should be noted somewhere.
|
Ah yes, I totally missed the update / workflow / contributor part. Thanks ! |
|
@jnoordsij @darkweaver87 I updated Guidelines and added a github action which fails when schema is not updated. Anything to add / remove / improve before merge ? |
| @@ -22,6 +22,14 @@ jobs: | |||
| run: | | |||
| git config user.name "$GITHUB_ACTOR" | |||
| git config user.email "[email protected]" | |||
| - name: Check if values schema is up-to-date | |||
There was a problem hiding this comment.
Maybe we should also add - [ ] Yes, I updated the values and updated schema with `make schema` to the PR template as a guide for people?
mloiseleur
force-pushed
the
feat/schema
branch
from
53ca431
to
7272058
Compare
What does this PR do?
Introduce usage of https://github.com/losisin/helm-values-schema-json to generate a schema from values reading annotations from comments
Motivation
Fixes #1140
More
make testand all the tests passed