testing: Replace _TestMethodWrapper with _callTestMethod #3382
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Overriding _callTestMethod (which was introduced in python 3.8) is a less hacky way to detect tests that fail to use ``@gen_test`` where needed. It's not documented, but since Python 3.11 has introduced a similar check to the standard library we'll be able to remove it in the near future. The major impetus for this change is an incompatibility with Pytest 8.2, which has made a change that tries to instantiate test classes at discovery time without an existing method name. Fixes tornadoweb#3375 Closes tornadoweb#3374
|
@bdarnell Any plans to create a new release with this fix? |
dave-shawley
added a commit
to dave-shawley/tornado-problem-details
that referenced
this pull request
Jun 5, 2024
This is fixed in the mainline but I'm going to downgrade pytest for the time being. tornadoweb/tornado#3382
dave-shawley
added a commit
to dave-shawley/tornado-problem-details
that referenced
this pull request
Jun 5, 2024
This is fixed in the mainline but I'm going to downgrade pytest for the time being. tornadoweb/tornado#3382
|
This was included in 6.4.1 that went out yesterday. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overriding _callTestMethod (which was introduced in python 3.8) is a less hacky way to detect tests that fail to use
@gen_testwhere needed. It's not documented, but since Python 3.11 has introduced a similar check to the standard library we'll be able to remove it in the near future.The major impetus for this change is an incompatibility with Pytest 8.2, which has made a change that tries to instantiate test classes at discovery time without an existing method name.
Fixes #3375
Closes #3374