Client should now respect the maxBatchSize setting from the server #94
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also added to log output how many requests used Bytestream vs CAS
|
Will add @tdyas as a reviewer once he accepts the invite (he may be interested in toolchain's IP more generally) |
|
Thanks @Faqa - review pending. Please ping here if we don't get back to you in a few days. |
|
@benjyw - Pinging as requested (The build failure doesn't seem to be anything under my control?) |
|
@Faqa - can you merge latest main into this branch? I fixed some CI bitrot there, so that should get this PR to pass CI. Thanks! |
|
@Faqa actually - wait until I fix the publishing CI job too... I'll ping here when it's good. |
|
@Faqa - OK, CI is fixed, so if you merge latest main onto your branch your CI should pass, and we can merge. Thanks for your patience! |
Use scie-pants, and update CI to recent actions versions.
|
Merged, thanks again @Faqa |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also added to log output how many requests used Bytestream vs CAS