Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

the doc-test for backtrace::SpanTrace::capture uses the attributes feature from tracing #2698

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

alexanderkjall
Copy link

Running cargo test in tracing-error without this change:

---- src/backtrace.rs - backtrace::SpanTrace::capture (line 79) stdout ----
error[E0433]: failed to resolve: could not find `instrument` in `tracing`
  --> src/backtrace.rs:90:12
   |
14 | #[tracing::instrument]
   |            ^^^^^^^^^^ could not find `instrument` in `tracing`

error: aborting due to previous error

For more information about this error, try `rustc --explain E0433`.
Couldn't compile the test.

failures:
    src/backtrace.rs - backtrace::SpanTrace::capture (line 79)

test result: FAILED. 11 passed; 1 failed; 0 ignored; 0 measured; 0 filtered out; finished in 0.50s

Motivation

Discovered when packaging the crate for Debian.

Solution

Pull in the required feature as a dev-dependency.

@alexanderkjall alexanderkjall requested review from yaahc and a team as code owners August 28, 2023 14:12
@alexanderkjall
Copy link
Author

I looked at the build failures, and they don't look relevant to this PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants