fix(core): circular dependency in pdf embed view #9331
Merged
+31
−40
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
How to use the Graphite Merge QueueAdd either label to this PR to merge it via the merge queue:
You must have a Graphite account in order to use the merge queue. Sign up using this link. An organization admin has enabled the Graphite Merge Queue in this repository. Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue. This stack of pull requests is managed by Graphite. Learn more about stacking. |
graphite-app
bot
requested review from
CatsJuice,
JimmFly,
pengx17,
forehalo and
EYHN
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## canary #9331 +/- ##
==========================================
+ Coverage 51.43% 51.49% +0.06%
==========================================
Files 2155 2155
Lines 97670 97670
Branches 16385 16388 +3
==========================================
+ Hits 50234 50297 +63
+ Misses 46047 45982 -65
- Partials 1389 1391 +2
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
fundon
force-pushed
the
fundon/12_26_fix_dependency_cycle_issue
branch
5 times, most recently
from
b55506e to
4331a55
Compare
doodlewind
approved these changes
Dec 26, 2024
fundon
force-pushed
the
fundon/12_26_fix_dependency_cycle_issue
branch
3 times, most recently
from
985fa53 to
647b7b0
Compare
Merge activity
|
fundon
force-pushed
the
fundon/12_26_fix_dependency_cycle_issue
branch
3 times, most recently
from
37575cb to
8ded739
Compare
fundon
changed the title
fundon
force-pushed
the
fundon/12_26_fix_dependency_cycle_issue
branch
from
8ded739 to
07e8dee
Compare
fundon
added a commit
that referenced
this pull request
Dec 26, 2024
fundon
force-pushed
the
fundon/12_26_fix_dependency_cycle_issue
branch
from
07e8dee to
b2c629e
Compare
fundon
added a commit
that referenced
this pull request
Dec 27, 2024
fundon
force-pushed
the
fundon/12_26_fix_dependency_cycle_issue
branch
from
b2c629e to
cb775ac
Compare
EYHN
approved these changes
Dec 27, 2024
fundon
added a commit
that referenced
this pull request
Dec 27, 2024
fundon
force-pushed
the
fundon/12_26_fix_dependency_cycle_issue
branch
from
cb775ac to
88b224a
Compare
fundon
force-pushed
the
fundon/12_26_fix_dependency_cycle_issue
branch
from
88b224a to
20c5c28
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.