llms/openai: Optionally supply ResponseFormat (#690)

* fix: ResponseFormat cause openai api response err - is not one of ['json_object', 'text'] - 'response_format.type'
tmc · Mar 19, 2024 · 8b54683 · 8b54683
1 parent 4065971
commit 8b54683
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 4 deletions.
diff --git a/llms/openai/internal/openaiclient/chat.go b/llms/openai/internal/openaiclient/chat.go
@@ -33,7 +33,7 @@ type ChatRequest struct {
 	FrequencyPenalty float64        `json:"frequency_penalty,omitempty"`
 	PresencePenalty  float64        `json:"presence_penalty,omitempty"`
 
-	ResponseFormat ResponseFormat `json:"response_format,omitempty"`
+	ResponseFormat *ResponseFormat `json:"response_format,omitempty"`
 
 	// Function definitions to include in the request.
 	Functions []FunctionDefinition `json:"functions,omitempty"`

diff --git a/llms/openai/openaillm_option.go b/llms/openai/openaillm_option.go
@@ -33,7 +33,7 @@ type options struct {
 	apiType      APIType
 	httpClient   openaiclient.Doer
 
-	responseFormat ResponseFormat
+	responseFormat *ResponseFormat
 
 	// required when APIType is APITypeAzure or APITypeAzureAD
 	apiVersion     string
@@ -49,7 +49,7 @@ type Option func(*options)
 type ResponseFormat = openaiclient.ResponseFormat
 
 // ResponseFormatJSON is the JSON response format.
-var ResponseFormatJSON = ResponseFormat{Type: "json_object"} //nolint:gochecknoglobals
+var ResponseFormatJSON = &ResponseFormat{Type: "json_object"} //nolint:gochecknoglobals
 
 // WithToken passes the OpenAI API token to the client. If not set, the token
 // is read from the OPENAI_API_KEY environment variable.
@@ -124,7 +124,7 @@ func WithCallback(callbackHandler callbacks.Handler) Option {
 }
 
 // WithResponseFormat allows setting a custom response format.
-func WithResponseFormat(responseFormat ResponseFormat) Option {
+func WithResponseFormat(responseFormat *ResponseFormat) Option {
 	return func(opts *options) {
 		opts.responseFormat = responseFormat
 	}