Consolidated version of all outstanding PRs. #18
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Add Bleichenbacher reference
It also limits its scope to TLS 1.2 and below, so we do not need to Update: it anymore. Remove text discussing the update, and use the new reference as appropriate. Retain "coauthor of RFC 4492" in the contributors section.
kaduk
suggested changes
Aug 5, 2018
rfc8446.xml
Outdated
| @@ -4558,6 +4556,11 @@ target="extensions"/>, with any extension not listed there marked as "-" to | |||
| indicate that it is not used by TLS 1.3.</t> | |||
| </list></t> | |||
|
|
|||
| <t>This document updates an entry in the TLS Certificate Types registry | |||
| originally created in <xref target="RFC6091"></xref>. The entry for value 1 | |||
There was a problem hiding this comment.
I think in some other places we've done "created in [blah] and updated in [blah]", which might be appropriate here.
There was a problem hiding this comment.
What was it updated in? 7250?
rfc8446.xml
Outdated
| @@ -6412,7 +6419,7 @@ from older TLS implementations.</t> | |||
| ]]></artwork></figure> | |||
|
|
|||
| <t>Values within "obsolete_RESERVED" ranges are used in previous versions | |||
| of TLS and MUST NOT be offered or negotiated by TLS 1.3 implementations. | |||
| of TLS and MUST NOT be offered by TLS 1.3 implementations. | |||
There was a problem hiding this comment.
This is a normative change; did you intend to include it?
kaduk
approved these changes
Aug 5, 2018
chris-wood
approved these changes
Aug 5, 2018
chris-wood
requested changes
Aug 6, 2018
rfc8446.xml
Outdated
| @@ -6067,6 +6075,7 @@ from older TLS implementations.</t> | |||
| alert(21), | |||
| handshake(22), | |||
| application_data(23), | |||
| heartbeat(24), | |||
There was a problem hiding this comment.
Can you add /* RFC 6520 */ after this line, as we did for the extension table above?
chris-wood
approved these changes
Aug 6, 2018
|
lgtm |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@chris-wood, @kaduk