Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Edit group: navigate to ChatList (home) after group deletion #3923

Draft
wants to merge 1 commit into
base: develop
Choose a base branch
from
Draft

Edit group: navigate to ChatList (home) after group deletion #3923

wants to merge 1 commit into from

Conversation

jamesacklin
Copy link
Member

Navigates the user to ChatList once they delete a group. Fixes TLON-2680

@linear Linear
Copy link

linear bot commented Sep 16, 2024

TLON-2680 Deleting group does not close sheet

patosullivan
patosullivan requested changes Sep 17, 2024
View reviewed changes
Copy link
Member

@patosullivan patosullivan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can't use react-navigation within the app package, the navigation action would need to be defined externally in the web and native controllers and then passed into GroupMetaScreen as a prop.

@jamesacklin jamesacklin marked this pull request as draft September 17, 2024 23:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@patosullivan patosullivan patosullivan requested changes

@dnbrwstr dnbrwstr Awaiting requested review from dnbrwstr

@latter-bolden latter-bolden Awaiting requested review from latter-bolden

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jamesacklin @patosullivan