Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fwconsole: add page #15350

Open
wants to merge 6 commits into
base: main
Choose a base branch
from
Open

fwconsole: add page #15350

wants to merge 6 commits into from

Conversation

aqeelabpro
Copy link

  • The page(s) are in the correct platform directories: common, linux, osx, windows, sunos, android, etc.
  • The page(s) have at most 8 examples.
  • The page description(s) have links to documentation or a homepage.
  • The page(s) follow the content guidelines.
  • The page(s) follow the style guide.
  • The PR title conforms to the recommended templates.
  • Version of the command being documented (if known): 16.0.40.11

@aqeelabpro aqeelabpro requested a review from cyqsimon as a code owner December 25, 2024 10:46
@github-actions github-actions bot added the new command Issues requesting creation of a new page. label Dec 25, 2024
spageektti
spageektti reviewed Dec 25, 2024
View reviewed changes
Copy link
Member

@spageektti spageektti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi. Thanks for your contribution. I wish a wonderful christmas time!

pages/linux/fwconsole.md Outdated Show resolved Hide resolved
@aqeelabpro @spageektti
Update pages/linux/fwconsole.md
2d33701 
Co-authored-by: Wiktor Perskawiec <[email protected]>
spageektti
spageektti reviewed Dec 25, 2024
View reviewed changes
pages/linux/fwconsole.md Outdated
# fwconsole

> Manage and configure your FreePBX system (PBX server).
> More information: <https://wiki.freepbx.org>.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
> More information: <https://wiki.freepbx.org>.
> More information: <https://sangomakb.atlassian.net/wiki/spaces/FP/overview>.

the link you provided redirects to this site

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Or maybe use this one?
https://sangomakb.atlassian.net/wiki/spaces/PG/pages/41746505/fwconsole+commands+15

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

When I was testing locally, I added this https://sangomakb.atlassian.net/wiki/spaces/PG/pages/41779247/fwconsole+commands+13
but I thought it was a long URL, so I just added the https://wiki.freepbx.org, which directs to the same website, ok, I will change it to https://sangomakb.atlassian.net/wiki/spaces/PG/pages/41779247/fwconsole+commands+13

spageektti
spageektti reviewed Dec 25, 2024
View reviewed changes
pages/linux/fwconsole.md Outdated

`fwconsole list`

- Change ownership of files:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
- Change ownership of files:
- Change ownership of all files and directories that FreePBX needs to be owned by the apache user:

pages/linux/fwconsole.md Outdated

`fwconsole reload`

- Start Asterisk and run other needed FreePBX commands:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
- Start Asterisk and run other needed FreePBX commands:
- Start Asterisk and other commands needed by FreePBX:

pages/linux/fwconsole.md Outdated

`fwconsole start`

- Stop Asterisk and run other needed FreePBX commands:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
- Stop Asterisk and run other needed FreePBX commands:
- Stop Asterisk and other commands needed by FreePBX:

aqeelabpro
aqeelabpro commented Dec 26, 2024
View reviewed changes
Copy link
Author

@aqeelabpro aqeelabpro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your suggestion! I've made the necessary changes to the link based on your feedback.
Apologies for any confusion earlier—this is my first contribution, and I’m learning as I go.
Please let me know if there’s anything else I can improve.

@sebastiaanspeck
Copy link
Member

I reopened the closed suggestions that were not applied. Please apply them or explain why you do not apply them before resolving.

aqeelabpro
aqeelabpro commented Dec 26, 2024
View reviewed changes
Copy link
Author

@aqeelabpro aqeelabpro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Resolved the suggested changes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@spageektti spageektti spageektti left review comments

@cyqsimon cyqsimon Awaiting requested review from cyqsimon cyqsimon is a code owner

At least 2 approving reviews are required to merge this pull request.

Assignees
No one assigned
Labels
new command Issues requesting creation of a new page.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@aqeelabpro @sebastiaanspeck @spageektti