This repository has been archived by the owner on Dec 16, 2022. It is now read-only.
[Draft] Control vtgate buffer polling with mysql_conn_buffer_polling parameter #254
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brirams
reviewed
Aug 10, 2022
| @@ -183,31 +186,32 @@ type Listener struct { | |||
| PreHandleFunc func(context.Context, net.Conn, uint32) (net.Conn, error) | |||
| } | |||
|
|
|||
| // NewFromListener creates a new mysql listener from an existing net.Listener | |||
| func NewFromListener(l net.Listener, authServer AuthServer, handler Handler, connReadTimeout time.Duration, connWriteTimeout time.Duration) (*Listener, error) { | |||
| // NewFromListener creares a new mysql listener from an existing net.Listener | |||
Comment on lines
+1
to
+2
| //go:build gofuzz | ||
| // +build gofuzz |
There was a problem hiding this comment.
unclear what this change is about. should we revert it?
| @@ -13,7 +16,6 @@ WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | |||
| See the License for the specific language governing permissions and | |||
| limitations under the License. | |||
| */ | |||
| // +build gofuzz | |||
Comment on lines
+264
to
+265
| c.bufferedReader.Reset(nil) | ||
| readersPool.Put(c.bufferedReader) |
There was a problem hiding this comment.
would be worth checking that the bufferedReader isn't nil before doing this.
brirams
reviewed
Aug 10, 2022
| @@ -72,6 +72,11 @@ var ( | |||
| mysqlConnWriteTimeout = flag.Duration("mysql_server_write_timeout", 0, "connection write timeout") | |||
| mysqlQueryTimeout = flag.Duration("mysql_server_query_timeout", 0, "mysql query timeout") | |||
|
|
|||
| // TODO: enable this once the loadtest is done | |||
| // mysqlConnBufferPooling = flag.Bool("mysql_conn_buffer_polling", false, "If set, vtgate will pool connection buffers") | |||
There was a problem hiding this comment.
nit for later: would rename flag to have consistent prefix with other flags in this file. something like mysql_server_read_conn_pooling? would also update flag description to specify that it's connection reading as connection writing is already pooled.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adding an option for the vtgate to pool the connection buffer instead of creating new buffer for each new connection.
Related Issue(s)
Slack vtgate doses