Support custom ancestor container #50
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is a more customizable than the one suggested in third774#17. It should also be a non-breaking change as `container` is optional. If a user did not pass `container` as option, we fall back to the current behaviour.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi @third774,
in reference to #17, I propose a small change to the library so that users can pass in a custom ancestor container as option to the FocusedImage class.
I extend the FocusedImageOption interface by an optional
containerparameter and fall back to the current behaviour as this should not break any user code. Please feel free to review and discuss this PR.Thank you for maintaining this library.