Puppet 6 adjustment #137
Open
Puppet 6 adjustment #137
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Advise on how to proceed; I'm not sure there's an option on maintaining two different branches of a module, allowing for compatibility on two different versions, aside from explicit versioning. Also, I'm not sure if anything really breaks when using the dependency, as most people don't enforce dependencies when using |
Since P6 has removed the `nagios_*` types from the core, we'll need to put in an external dependency on them. Since I'm not sure how breaking this change would be, I just bumped up the Puppet dependency for sake of saving automation from itself.
|
Pretty confident by now that you're either adding the dependencies anyway or it won't break people's stuff, so this should just be easily mergable. |
|
Bump? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since P6 has removed the
nagios_*types from the core, we'll need toput in an external dependency on them.
Since I'm not sure how breaking this change would be, I just bumped up
the Puppet dependency for sake of saving automation from itself.