Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Delete Dimension #650

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

ahmedrizwan239
Copy link

Implementation of the deleteDimension api call.

@theoephraim
Copy link
Owner

nice! Thanks :D

To make the DX slightly easier, I think I might

  • make 2 methods deleteRows and deleteColumns - this could be in addition to deleteDimension, and could just call deleteDimension internally
  • unwrap the start/end params from the object (ie deleteRows(start, end)) but be sure to handle the undefined case (google's api lets you have it unbounded on one side)

It's all fairly subjective, but it's sort of the fun part in trying to design a more intuitive interface for users than google's apis, which is what this module is all about.

Also we'll need to add tests and docs before merging.
Feel free to continue, or leave it as is and I'll add the rest before merging.

Cheers and thanks!

@ahmedrizwan239
Copy link
Author

Can you please merge this asap? I need to use it in my package for a project. This would help, Thanks!

@cesar3030
Copy link

Agree, could this be merged please?

@fernandohg97
Copy link

This will work great in my project! Could this be merged please?

@TRMoosee
Copy link

Could definitely use this on a project I'm working on, is there any way we could get this merged soon?

@ururk
Copy link

ururk commented May 15, 2024

Could use this as well!

@ururk
Copy link

ururk commented May 15, 2024

@theoephraim It looks like some changes you suggested still need to be done... should I fork @ahmedrizwan239 fork or make my own?

@theoephraim
Copy link
Owner

@ururk - yeah if you're up for it, got for it! The functionality itself is pretty simple, but need to add tests, docs, and ideally make the DX a little simpler... Otherwise I'll try to get to it asap

@ururk
Copy link

ururk commented May 15, 2024

I'm taking stab at it, hopefully have something for today. I have the two additional methods written and was looking at your tests

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants