Protect the use of document to resolve SSR issues. #47
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
To enable inclusion in applications that *may also use* SSR, the invocation of `document.createRange()` needs to be moved out of the global scope. Moving it into the `parseHTML()` method resolves this issue since it will only be executed if the component is actually used (on the browser side). Full inclusion of this component by flowbite 2.4.0 introduced SSR-related bugs across multiple frameworks (Nuxt, NextJS, Sveltekit) due to this unprotected use of `document`. Prior to flowbite 2.4.0, flowbite-datepicker was included via a "plugin" approach that mitigated this unprotected use of `document`, This resolves issue themesberg#41
20x-dz
reviewed
Sep 27, 2024
Accept the suggested change from `var` to `let` Co-authored-by: 20x-dz <[email protected]>
|
I am having this same issue as well when trying to import flowbite into a Deno Fresh project using SSR. I applied the fix to the file and it did resolve my issue. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To enable inclusion in applications that may also use SSR, the invocation of
document.createRange()needs to be moved out of the global scope. Moving it into theparseHTML()method resolves this issue since it will only be executed if the component is actually used (on the browser side).Full inclusion of this component by flowbite 2.4.0 introduced SSR-related bugs across multiple frameworks (Nuxt, NextJS, Sveltekit) due to this unprotected use of
document.Prior to flowbite 2.4.0, flowbite-datepicker was included via a "plugin" approach that mitigated this unprotected use of
document,This resolves issue #41