Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Soap Trace Output to STDERR #1

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

dan-fynanz
Copy link

While going through the certification process with Russ, he requested a SOAP Trace. I've added a line to the docusignDriver.rb APIServiceSoap class which will output this trace to STDERR automatically when the rails app is run in the development environment. This will work for modern (tested 2.3.2 and up) versions of rails, but may not in older versions, so I put a rescue nil at the end of the line.

@texel
Copy link
Owner

texel commented Mar 8, 2011

Hi Dan, thanks for the pull request. I'm a bit concerned, for a couple of reasons. First, this assumes that a user of the gem is going to be using Rails, and that's not necessarily the case, although you did remind me that I have an implicit dependency on ActiveSupport that I really need to make explicit. Second, it assumes that a user always wants to output to STDERR, and always want to do so in development mode.

I'd much prefer making this a simple configuration option, something to the effect of:
# in config/environments/development.rb
config.to_prepare do
Docusign::CONFIG['wiredump_dev'] = STDERR
end

This way, we could just check for that key on the config hash, and not swallow any and every error that might come our way.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants