Skip to content

Commit

Permalink
Drop python 3.7 support
Browse files Browse the repository at this point in the history
  • Loading branch information
jelmer committed Jun 12, 2024
1 parent 1828135 commit 89c502d
Show file tree
Hide file tree
Showing 6 changed files with 7 additions and 13 deletions.
2 changes: 1 addition & 1 deletion .github/workflows/ci.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@ jobs:
runs-on: ubuntu-latest
strategy:
matrix:
python: ["3.7", "3.8", "3.9", "3.10", "3.11", "3.12", "pypy-3.7", "pypy-3.8", "pypy-3.9"]
python: ["3.8", "3.9", "3.10", "3.11", "3.12", "pypy-3.8", "pypy-3.9"]
steps:
- name: Checkout source code
uses: actions/checkout@v3
Expand Down
2 changes: 1 addition & 1 deletion Makefile
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
PYTHON ?= python
PYTHON ?= python3

all: check

Expand Down
3 changes: 3 additions & 0 deletions NEWS
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,9 @@ NEXT
* Drop support for Python 3.6 (EOL)
(Stephen Finucane)

* Drop support for Python 3.7 (EOL)
(Jelmer Vernooij)

* Add a new ``WarningsFilter`` filter, allowing users to filter warnings as
part of their tests, before restoring said filters.
(Stephen Finucane)
Expand Down
2 changes: 1 addition & 1 deletion README.rst
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@ provided that makes using fixtures that meet the ``Fixtures`` contract in
Dependencies
============

* Python 3.7+
* Python 3.8+
This is the base language fixtures is written in and for.

* ``pbr``
Expand Down
8 changes: 0 additions & 8 deletions fixtures/_fixtures/popen.py
Original file line number Diff line number Diff line change
Expand Up @@ -153,14 +153,6 @@ def __call__(
pipesize=_unpassed,
process_group=_unpassed
):
# Reject arguments introduced by newer versions of Python in older
# versions; this makes it harder to accidentally hide compatibility
# problems using test doubles.
if sys.version_info < (3, 7) and text is not FakePopen._unpassed:
raise TypeError(
"FakePopen.__call__() got an unexpected keyword argument "
"'text'"
)
if sys.version_info < (3, 9):
for arg_name in "group", "extra_groups", "user", "umask":
if locals()[arg_name] is not FakePopen._unpassed:
Expand Down
3 changes: 1 addition & 2 deletions setup.cfg
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@ description_content_type = text/x-rst; charset=UTF-8
author = Robert Collins
author_email = [email protected]
url = https://github.com/testing-cabal/fixtures
python_requires = >=3.7
python_requires = >=3.8
classifiers =
Development Status :: 6 - Mature
Intended Audience :: Developers
Expand All @@ -16,7 +16,6 @@ classifiers =
Operating System :: OS Independent
Programming Language :: Python
Programming Language :: Python :: 3
Programming Language :: Python :: 3.7
Programming Language :: Python :: 3.8
Programming Language :: Python :: 3.9
Programming Language :: Python :: 3.10
Expand Down

0 comments on commit 89c502d

Please sign in to comment.