Move the initializer into the constructor for instance members that r… #6921
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
arcra
approved these changes
Sep 26, 2024
…eference identifiers declared in the constructor.
This updates our OSS code with a change made in cl/678990911, to prevent
the change being reverted the next time we sync into our internal code
base.
When TypeScript outputs modern language features, the below case throws an TS error.
```
class C {
a = this.x; // TS2729: Property 'x' is used before its initialization.
constructor(public x:number){}
}
```
This error is fixed by moving the initializer of such class members into
the constructor.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…eference identifiers declared in the constructor.
This updates our OSS code with a change made in cl/678990911, to prevent the change being reverted the next time we sync into our internal code base.
When TypeScript outputs modern language features, the below case throws an TS error.
This error is fixed by moving the initializer of such class members into the constructor.