Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

HParams: Stop passing controlsEnabled boolean to DataTable #6468

Merged
merged 1 commit into from
Jun 28, 2023
Merged

HParams: Stop passing controlsEnabled boolean to DataTable #6468

merged 1 commit into from
Jun 28, 2023

Conversation

JamesHollyer
Copy link
Contributor

@JamesHollyer JamesHollyer commented Jun 28, 2023 •
edited
Loading

Motivation for features / changes

This boolean was removed in #6463. However, I forgot to remove it from being passed in the ScalarCardDataTable. This was caught in an internal build.

rileyajones
rileyajones approved these changes Jun 28, 2023
View reviewed changes
Copy link
Contributor

@rileyajones rileyajones left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM assuming this syncs in properly cl/543939582

@JamesHollyer JamesHollyer merged commit 44f47ef into tensorflow:master Jun 28, 2023
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rileyajones rileyajones rileyajones approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@JamesHollyer @rileyajones