Remove requirement that metricInfos are present to show Hparams main view. #6452
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for features / changes
We are building some new hparams-related functionality internally. It is early stages and the data we return to the UI does not contain metrics. The hparams dashboard, however, requires
metricInfosto be non-empty in order to show the main view of the dashboard. We want to show the main view despite not having metric data.More generally, though, it doesn't seem like metric data should be a requirement to show hparam dashboard information. The hparams fields can still be valuable on their own.
Technical description of changes
Remove a UI-level check for non-empty metricInfos.