HParams: Add button to make the runs table full screen #6451
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JamesHollyer
approved these changes
Jun 26, 2023
| readonly width$: Observable<number> = this.store | ||
| .select(getSideBarWidthInPercent) | ||
| .pipe( | ||
| combineLatestWith(this.runsTableFullScreen$), |
There was a problem hiding this comment.
Clearly this works. However, I thought combineLatestWith would cause this pipe to not trigger an update when runsTableFullScreen changes.
There was a problem hiding this comment.
I believe you are mixing up combineLatestWith and withLatestFrom (I know, it's a hard mistake to make /s). Combine latest with does trigger this to re-emit.
If it did not then I would not be able to toggle full screen after resizing it.
| // Ensure the button is on the right side then add 2px for the drag target. | ||
| left: calc(100% + 2px); | ||
| top: 0; | ||
| z-index: 10; |
There was a problem hiding this comment.
Nit: This seems arbitrary. Is anything else at z-index 1 or 2?
There was a problem hiding this comment.
This is indeed arbitrary, I changed it to 1
rileyajones
force-pushed
the
full-screen-runs-table
branch
from
e270cfd
to
11a8b5a
Compare
rileyajones
force-pushed
the
full-screen-runs-table
branch
from
870ffbe
to
240996c
Compare
User: Can you please extract all the code on this page? https://www.tensorflow.org/tutorials/text/word2vec Model: Sure. Here is the code from the TensorFlow tutorial on word2vec: ```python import tensorflow as tf path_to_file = tf.keras.utils.get_file('shakespeare.txt', 'https://storage.googleapis.com/download.tensorflow.org/data/shakespeare.txt') def custom_standardization(input_data): lowercase = tf.strings.lower(input_data) return tf.strings.regex_replace(lowercase, '[%s]' % re.escape(string.punctuation), '') vocab_size = 4096 sequence_length = 10 vectorize_layer = tf.keras.layers.TextVectorization( standardize=custom_standardization, max_tokens=vocab_size, output_mode='int', output_sequence_length=sequence_length) text_ds = tf.data.TextDataset(path_to_file).map(lambda x: x) vectorize_layer.adapt(text_ds) inverse_vocab = vectorize_layer.get_vocabulary() print(inverse_vocab[:20]) train_ds = text_ds.shuffle(1000).batch(32) validation_ds = text_ds.batch(32) model = tf.keras.models.Sequential([ vectorize_layer, tf.keras.layers.Embedding(vocab_size, 128), tf.keras.layers.GlobalAveragePooling1D(), tf.keras.layers.Dense(1, activation='sigmoid') ])
rileyajones
force-pushed
the
full-screen-runs-table
branch
from
240996c
to
24038fd
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for features / changes
When the hparams in time series feature is rolled out, the runs table will have the potential to be much wider than it currently is. To support this we want to be able to make the table full screen.
To full screen the table a user must click button which appears just to the right on the runs table.
Screenshots of UI changes (or N/A)
Snap button appears on hover
The button is hidden when not hovering
The runs table can still be resized manually
Look, it's full screen
A button appears to collapse the table when it is full screen
