Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Card Interactions: Add redux logic store and retrieve card suggestions #6437

Draft
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

rileyajones
Copy link
Contributor

Motivation for features / changes

We are working on a new feature to suggest cards to a user based on their previous interactions with TensorBoard.
This is just the initial change adding the redux logic. Another pr will follow this shortly adding the display.

For Googlers see go/tb-suggested-cards

See #6436 for the feature flag being added.

Technical description of changes

  • I'm adding a new action which is dispatched whenever a user clicks anywhere on a metrics card.
  • I am adding a new data source and effect file to record these interactions to localStorage, then rehydrate them

Screenshots of UI changes (or N/A)

When the UI is added it will look something like this.
image

Alternate designs / implementations considered (or N/A)

Rather than adding two state attributes I could have only added one and relied on newly written events being stored to localStorage. I found this approach to be cleaner as it limited the amount of places the code had to communicate with localStorage.

The number of cards being displayed is arbitrarily limited to 10, with the additional arbitrary constraints of 3 based on tag filters, and 3 based on clicks.

@rileyajones rileyajones force-pushed the card-interactions branch 3 times, most recently from 17a28b7 to dad33c2 Compare June 15, 2023 22:30
@rileyajones rileyajones marked this pull request as ready for review June 16, 2023 17:03
@rileyajones rileyajones marked this pull request as draft June 16, 2023 17:06
rileyajones added a commit that referenced this pull request Sep 14, 2023
…to localStorage (#6439)

## Motivation for features / changes
We are working on a feature to suggest cards to users at the top of the
timeseries dashboard. Suggestions are generated based on previous
interactions with TensorBoard. In order to determine what those previous
interactions were we are storing them to localStorage.
See #6437 for more information.
Googlers see [go/tb-suggested-cards](go/tb-suggested-cards)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant