Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: inconsistent single host multi-device distributed guide #2246

Merged
merged 1 commit into from
Jul 17, 2023
Merged

fix: inconsistent single host multi-device distributed guide #2246

merged 1 commit into from
Jul 17, 2023

Conversation

yangwu1227
Copy link
Contributor

In reference to the Keras documentation regarding single-host multi-device training, both model creation and compilation are advised to be executed within the strategy.scope. However, the official TensorFlow guide shows model.compile(...) outside of strategy.scope. Possible inconsistency? Appreciate any clarification on this matter and I've opened this PR just in case. Thank you.

@yangwu1227 yangwu1227 requested a review from a team as a code owner July 16, 2023 07:29
@google-cla
Copy link

google-cla bot commented Jul 16, 2023

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

@github-actions
Copy link

Preview

Preview and run these notebook edits with Google Colab: Rendered notebook diffs available on ReviewNB.com.

Format and style

Use the TensorFlow docs notebook tools to format for consistent source diffs and lint for style:
$ python3 -m pip install -U --user git+https://github.com/tensorflow/docs

$ python3 -m tensorflow_docs.tools.nbfmt notebook.ipynb
$ python3 -m tensorflow_docs.tools.nblint --arg=repo:tensorflow/docs notebook.ipynb
If commits are added to the pull request, synchronize your local branch: git pull origin fix-inconsistent-distributed-guide

@MarkDaoust MarkDaoust added the ready to pull Start merge process label Jul 17, 2023
Copy link
Member

@MarkDaoust MarkDaoust left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks.

@github-actions github-actions bot added the lgtm Community-added approval label Jul 17, 2023
@copybara-service copybara-service bot merged commit 37bb665 into tensorflow:master Jul 17, 2023
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lgtm Community-added approval ready to pull Start merge process
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants