Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow sphero gem to optionally use rs232 gem for serial communication #2

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

macumber
Copy link

Hey there, your sphero library is great but I could not get it working on Windows using the serialport gem. I was able to get it working with the rs232 gem after I made a patch (that patch has already been merged). If you are interested I tried to make the sphero library configurable about which gem to use for serial port communication. If you set the environment variable RUBY_SPHERO_RS232 it will use rs232, otherwise it will use serialport. Let me know if you're interested in these changes and if there are any changes you'd like me to make first.

Thanks again,
Dan

@madebydavid
Copy link

Hey Dan,

I run a small coding club for children and at the moment we're using KidsRuby. We just purchased a couple of Spheros and since we're running Windows machines, we're running into the problems which your pull request solves.

KidsRuby uses https://github.com/hybridgroup/sphero which is pretty far ahead of your fork now and so I have been having some problems merging your pull request into that. Is there any chance at all that you might be able to revise the pull request so that it works with the refactoring which has gone on in https://github.com/hybridgroup/sphero?

No probs if not - I'll just keep hacking.

Cheers,

D

@macumber
Copy link
Author

Hey @madebydavid glad my commit helped in some way :-) Unfortunately, my sphero died and I haven't replaced it so I can't test anything. Hopefully you can get it working some other way though, happy hacking!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants