Update dependencies, and add new linter with fixes (Vonage#212)

.golangci.yml

@@ -85,6 +85,7 @@ linters:
     - gocheckcompilerdirectives    # Checks that go compiler directive comments (//go:) are valid. [fast: true, auto-fix: false]
     - gochecknoglobals    # check that no global variables exist [fast: false, auto-fix: false]
     - gochecknoinits    # Checks that no init functions are present in Go code [fast: true, auto-fix: false]
+    - gochecksumtype  # Run exhaustiveness checks on Go "sum types" [fast: false, auto-fix: false]
     - gocognit    # Computes and checks the cognitive complexity of functions [fast: true, auto-fix: false]
     - goconst    # Finds repeated strings that could be replaced by a constant [fast: true, auto-fix: false]
     - gocritic    # Provides diagnostics that check for bugs, performance and style issues. [fast: false, auto-fix: false]
@@ -106,6 +107,7 @@ linters:
     - govet    # (vet, vetshadow): Vet examines Go source code and reports suspicious constructs, such as Printf calls whose arguments do not align with the format string [fast: false, auto-fix: false]
     - grouper    # An analyzer to analyze expression groups. [fast: true, auto-fix: false]
     - importas    # Enforces consistent import aliases [fast: false, auto-fix: false]
+    - inamedparam  # reports interfaces with unnamed method parameters [fast: true, auto-fix: false]
     - ineffassign    # Detects when assignments to existing variables are not used [fast: true, auto-fix: false]
     - interfacebloat    # A linter that checks the number of methods inside an interface. [fast: true, auto-fix: false]
     #- ireturn    # Accept Interfaces, Return Concrete Types [fast: false, auto-fix: false]
@@ -126,9 +128,11 @@ linters:
     - nonamedreturns    # Reports all named returns [fast: false, auto-fix: false]
     - nosprintfhostport    # Checks for misuse of Sprintf to construct a host with port in a URL. [fast: true, auto-fix: false]
     - paralleltest    # paralleltest detects missing usage of t.Parallel() method in your Go test [fast: false, auto-fix: false]
+    - perfsprint # Checks that fmt.Sprintf can be replaced with a faster alternative. [fast: false, auto-fix: false]
     - prealloc    # Finds slice declarations that could potentially be pre-allocated [fast: true, auto-fix: false]
     - predeclared    # find code that shadows one of Go's predeclared identifiers [fast: true, auto-fix: false]
     - promlinter    # Check Prometheus metrics naming via promlint [fast: true, auto-fix: false]
+    - protogetter # Reports direct reads from proto message fields when getters should be used [fast: false, auto-fix: true]
     - reassign    # Checks that package variables are not reassigned [fast: false, auto-fix: false]
     - revive    # Fast, configurable, extensible, flexible, and beautiful linter for Go. Drop-in replacement of golint. [fast: false, auto-fix: false]
     - rowserrcheck    # checks whether Err of rows is checked successfully [fast: false, auto-fix: false]
@@ -139,6 +143,7 @@ linters:
     #- tagliatelle    # Checks the struct tags. [fast: true, auto-fix: false]
     - tenv    # tenv is analyzer that detects using os.Setenv instead of t.Setenv since Go1.17 [fast: false, auto-fix: false]
     - testableexamples    # linter checks if examples are testable (have an expected output) [fast: true, auto-fix: false]
+    - testifylint # Checks usage of github.com/stretchr/testify. [fast: false, auto-fix: false]
     #- testpackage    # linter that makes you use a separate _test package [fast: true, auto-fix: false]
     - thelper    # thelper detects Go test helpers without t.Helper() call and checks the consistency of test helpers [fast: false, auto-fix: false]
     - tparallel    # tparallel detects inappropriate usage of t.Parallel() method in your Go test codes [fast: false, auto-fix: false]

Makefile

@@ -61,7 +61,7 @@ GOFMT=$(shell which gofmt)
 GOTEST=GOPATH=$(GOPATH) $(shell which gotest)
 GODOC=GOPATH=$(GOPATH) $(shell which godoc)
 GOLANGCILINT=$(BINUTIL)/golangci-lint
-GOLANGCILINTVERSION=v1.54.2
+GOLANGCILINTVERSION=v1.55.0
 
 # Directory containing the source code
 SRCDIR=./pkg

VERSION

@@ -1 +1 @@
-1.80.4
+1.80.5

examples/service/.golangci.yml

@@ -85,6 +85,7 @@ linters:
     - gocheckcompilerdirectives    # Checks that go compiler directive comments (//go:) are valid. [fast: true, auto-fix: false]
     - gochecknoglobals    # check that no global variables exist [fast: false, auto-fix: false]
     - gochecknoinits    # Checks that no init functions are present in Go code [fast: true, auto-fix: false]
+    - gochecksumtype  # Run exhaustiveness checks on Go "sum types" [fast: false, auto-fix: false]
     - gocognit    # Computes and checks the cognitive complexity of functions [fast: true, auto-fix: false]
     - goconst    # Finds repeated strings that could be replaced by a constant [fast: true, auto-fix: false]
     - gocritic    # Provides diagnostics that check for bugs, performance and style issues. [fast: false, auto-fix: false]
@@ -106,6 +107,7 @@ linters:
     - govet    # (vet, vetshadow): Vet examines Go source code and reports suspicious constructs, such as Printf calls whose arguments do not align with the format string [fast: false, auto-fix: false]
     - grouper    # An analyzer to analyze expression groups. [fast: true, auto-fix: false]
     - importas    # Enforces consistent import aliases [fast: false, auto-fix: false]
+    - inamedparam  # reports interfaces with unnamed method parameters [fast: true, auto-fix: false]
     - ineffassign    # Detects when assignments to existing variables are not used [fast: true, auto-fix: false]
     - interfacebloat    # A linter that checks the number of methods inside an interface. [fast: true, auto-fix: false]
     #- ireturn    # Accept Interfaces, Return Concrete Types [fast: false, auto-fix: false]
@@ -126,9 +128,11 @@ linters:
     - nonamedreturns    # Reports all named returns [fast: false, auto-fix: false]
     - nosprintfhostport    # Checks for misuse of Sprintf to construct a host with port in a URL. [fast: true, auto-fix: false]
     - paralleltest    # paralleltest detects missing usage of t.Parallel() method in your Go test [fast: false, auto-fix: false]
+    - perfsprint # Checks that fmt.Sprintf can be replaced with a faster alternative. [fast: false, auto-fix: false]
     - prealloc    # Finds slice declarations that could potentially be pre-allocated [fast: true, auto-fix: false]
     - predeclared    # find code that shadows one of Go's predeclared identifiers [fast: true, auto-fix: false]
     #- promlinter    # Check Prometheus metrics naming via promlint [fast: true, auto-fix: false]
+    - protogetter # Reports direct reads from proto message fields when getters should be used [fast: false, auto-fix: true]
     - reassign    # Checks that package variables are not reassigned [fast: false, auto-fix: false]
     - revive    # Fast, configurable, extensible, flexible, and beautiful linter for Go. Drop-in replacement of golint. [fast: false, auto-fix: false]
     - rowserrcheck    # checks whether Err of rows is checked successfully [fast: false, auto-fix: false]
@@ -139,6 +143,7 @@ linters:
     #- tagliatelle    # Checks the struct tags. [fast: true, auto-fix: false]
     - tenv    # tenv is analyzer that detects using os.Setenv instead of t.Setenv since Go1.17 [fast: false, auto-fix: false]
     - testableexamples    # linter checks if examples are testable (have an expected output) [fast: true, auto-fix: false]
+    - testifylint # Checks usage of github.com/stretchr/testify. [fast: false, auto-fix: false]
     #- testpackage    # linter that makes you use a separate _test package [fast: true, auto-fix: false]
     - thelper    # thelper detects Go test helpers without t.Helper() call and checks the consistency of test helpers [fast: false, auto-fix: false]
     - tparallel    # tparallel detects inappropriate usage of t.Parallel() method in your Go test codes [fast: false, auto-fix: false]

examples/service/.travis.yml

@@ -10,7 +10,7 @@ branches:
     - develop
 
 go:
-  - '1.18'
+  - '1.21'
 
 services:
   - docker

examples/service/Makefile

@@ -149,7 +149,7 @@ GOFMT=$(shell which gofmt)
 GOTEST=GOPATH=$(GOPATH) $(shell which gotest)
 GODOC=GOPATH=$(GOPATH) $(shell which godoc)
 GOLANGCILINT=$(BINUTIL)/golangci-lint
-GOLANGCILINTVERSION=v1.54.2
+GOLANGCILINTVERSION=v1.55.0
 
 # Current operating system and architecture as one string.
 GOOSARCH=$(shell go env GOOS GOARCH | tr -d \\n)

examples/service/go.mod

@@ -5,7 +5,7 @@ go 1.21
 replace github.com/Vonage/gosrvlib => ../..
 
 require (
-	github.com/Vonage/gosrvlib v1.80.4
+	github.com/Vonage/gosrvlib v1.80.5
 	github.com/golang/mock v1.6.0
 	github.com/jstemmer/go-junit-report v0.9.1
 	github.com/prometheus/client_golang v1.17.0
@@ -17,11 +17,11 @@ require (
 )
 
 require (
-	cloud.google.com/go v0.110.8 // indirect
-	cloud.google.com/go/compute v1.23.0 // indirect
+	cloud.google.com/go v0.110.9 // indirect
+	cloud.google.com/go/compute v1.23.1 // indirect
 	cloud.google.com/go/compute/metadata v0.2.3 // indirect
-	cloud.google.com/go/firestore v1.13.0 // indirect
-	cloud.google.com/go/longrunning v0.5.1 // indirect
+	cloud.google.com/go/firestore v1.14.0 // indirect
+	cloud.google.com/go/longrunning v0.5.2 // indirect
 	github.com/armon/go-metrics v0.4.1 // indirect
 	github.com/beorn7/perks v1.0.1 // indirect
 	github.com/cespare/xxhash/v2 v2.2.0 // indirect
@@ -30,17 +30,16 @@ require (
 	github.com/davecgh/go-spew v1.1.2-0.20180830191138-d8f796af33cc // indirect
 	github.com/dlmiddlecote/sqlstats v1.0.2 // indirect
 	github.com/fatih/color v1.15.0 // indirect
-	github.com/fsnotify/fsnotify v1.6.0 // indirect
-	github.com/gabriel-vasile/mimetype v1.4.2 // indirect
+	github.com/fsnotify/fsnotify v1.7.0 // indirect
+	github.com/gabriel-vasile/mimetype v1.4.3 // indirect
 	github.com/go-playground/locales v0.14.1 // indirect
 	github.com/go-playground/universal-translator v0.18.1 // indirect
 	github.com/go-playground/validator/v10 v10.15.5 // indirect
 	github.com/gogo/protobuf v1.3.2 // indirect
 	github.com/golang/groupcache v0.0.0-20210331224755-41bb18bfe9da // indirect
 	github.com/golang/protobuf v1.5.3 // indirect
-	github.com/google/go-cmp v0.5.9 // indirect
 	github.com/google/s2a-go v0.1.7 // indirect
-	github.com/googleapis/enterprise-certificate-proxy v0.3.1 // indirect
+	github.com/googleapis/enterprise-certificate-proxy v0.3.2 // indirect
 	github.com/googleapis/gax-go/v2 v2.12.0 // indirect
 	github.com/hashicorp/consul/api v1.25.1 // indirect
 	github.com/hashicorp/go-cleanhttp v0.5.2 // indirect
@@ -53,24 +52,24 @@ require (
 	github.com/inconshreveable/mousetrap v1.1.0 // indirect
 	github.com/json-iterator/go v1.1.12 // indirect
 	github.com/julienschmidt/httprouter v1.3.0 // indirect
-	github.com/klauspost/compress v1.17.0 // indirect
+	github.com/klauspost/compress v1.17.2 // indirect
 	github.com/leodido/go-urn v1.2.4 // indirect
 	github.com/magiconair/properties v1.8.7 // indirect
 	github.com/mattn/go-colorable v0.1.13 // indirect
-	github.com/mattn/go-isatty v0.0.19 // indirect
-	github.com/matttproud/golang_protobuf_extensions v1.0.4 // indirect
+	github.com/mattn/go-isatty v0.0.20 // indirect
+	github.com/matttproud/golang_protobuf_extensions/v2 v2.0.0 // indirect
 	github.com/mitchellh/go-homedir v1.1.0 // indirect
 	github.com/mitchellh/mapstructure v1.5.0 // indirect
 	github.com/modern-go/concurrent v0.0.0-20180306012644-bacd9c7ef1dd // indirect
 	github.com/modern-go/reflect2 v1.0.2 // indirect
-	github.com/nats-io/nats.go v1.30.2 // indirect
-	github.com/nats-io/nkeys v0.4.5 // indirect
+	github.com/nats-io/nats.go v1.31.0 // indirect
+	github.com/nats-io/nkeys v0.4.6 // indirect
 	github.com/nats-io/nuid v1.0.1 // indirect
 	github.com/pelletier/go-toml/v2 v2.1.0 // indirect
 	github.com/pkg/errors v0.9.1 // indirect
 	github.com/pmezard/go-difflib v1.0.1-0.20181226105442-5d4384ee4fb2 // indirect
 	github.com/prometheus/client_model v0.5.0 // indirect
-	github.com/prometheus/common v0.44.0 // indirect
+	github.com/prometheus/common v0.45.0 // indirect
 	github.com/prometheus/procfs v0.12.0 // indirect
 	github.com/sagikazarmark/crypt v0.15.0 // indirect
 	github.com/sagikazarmark/locafero v0.3.0 // indirect
@@ -89,20 +88,20 @@ require (
 	golang.org/x/crypto v0.14.0 // indirect
 	golang.org/x/exp v0.0.0-20231006140011-7918f672742d // indirect
 	golang.org/x/mod v0.13.0 // indirect
-	golang.org/x/net v0.16.0 // indirect
+	golang.org/x/net v0.17.0 // indirect
 	golang.org/x/oauth2 v0.13.0 // indirect
 	golang.org/x/sync v0.4.0 // indirect
 	golang.org/x/sys v0.13.0 // indirect
 	golang.org/x/text v0.13.0 // indirect
 	golang.org/x/time v0.3.0 // indirect
 	golang.org/x/tools v0.14.0 // indirect
-	golang.org/x/xerrors v0.0.0-20220907171357-04be3eba64a2 // indirect
-	google.golang.org/api v0.145.0 // indirect
+	golang.org/x/xerrors v0.0.0-20231012003039-104605ab7028 // indirect
+	google.golang.org/api v0.148.0 // indirect
 	google.golang.org/appengine v1.6.8 // indirect
-	google.golang.org/genproto v0.0.0-20231002182017-d307bd883b97 // indirect
-	google.golang.org/genproto/googleapis/api v0.0.0-20231002182017-d307bd883b97 // indirect
-	google.golang.org/genproto/googleapis/rpc v0.0.0-20231002182017-d307bd883b97 // indirect
-	google.golang.org/grpc v1.58.2 // indirect
+	google.golang.org/genproto v0.0.0-20231016165738-49dd2c1f3d0b // indirect
+	google.golang.org/genproto/googleapis/api v0.0.0-20231016165738-49dd2c1f3d0b // indirect
+	google.golang.org/genproto/googleapis/rpc v0.0.0-20231016165738-49dd2c1f3d0b // indirect
+	google.golang.org/grpc v1.59.0 // indirect
 	google.golang.org/protobuf v1.31.0 // indirect
 	gopkg.in/ini.v1 v1.67.0 // indirect
 	gopkg.in/yaml.v3 v3.0.1 // indirect