Improve quality of generated seed, avoid potential security pitfall #747
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Try to use random_bytes() first if it's available * Do not include the server parameters in the generated seed, as they might contain sensitive data As all current usages of getRandomSeed() directly hash the seed, there should be no BC breaking changes. The main source of entropy is more than enough on its own if random_bytes() or openssl_random_pseudo_bytes() are available.
xelan
force-pushed
the
bugfix/improve-random-seed-security
branch
from
3d14084
to
022689a
Compare
williamdes
approved these changes
Sep 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As all current usages of getRandomSeed() directly hash the seed, there should be no BC breaking changes.
The main source of entropy is more than enough on its own if random_bytes() or openssl_random_pseudo_bytes() are available.