refactor: 불필요한 뷰 제거

tasty-code · Mar 18, 2024 · dab8c27 · dab8c27
1 parent 05b38f2
commit dab8c27
Show file tree

Hide file tree

Showing 2 changed files with 19 additions and 30 deletions.
diff --git a/BoxOffice.xcodeproj/project.pbxproj b/BoxOffice.xcodeproj/project.pbxproj
@@ -18,14 +18,14 @@
 		0827984C2B88519900ACC723 /* MovieDetailInfo.swift in Sources */ = {isa = PBXBuildFile; fileRef = 0827984B2B88519900ACC723 /* MovieDetailInfo.swift */; };
 		0864FC632B9F2EE500CE0725 /* APIHostType.swift in Sources */ = {isa = PBXBuildFile; fileRef = 0864FC622B9F2EE500CE0725 /* APIHostType.swift */; };
 		0864FC652B9F318000CE0725 /* ViewControllerFactoryProtocol.swift in Sources */ = {isa = PBXBuildFile; fileRef = 0864FC642B9F318000CE0725 /* ViewControllerFactoryProtocol.swift */; };
-		0887A4FF2BA18B8800B69306 /* DEBUG-Keys.plist in Resources */ = {isa = PBXBuildFile; fileRef = 0887A4FE2BA18B8700B69306 /* DEBUG-Keys.plist */; };
 		08A6CE562B99A7C900F2F2CA /* NetworkManager.swift in Sources */ = {isa = PBXBuildFile; fileRef = 08A6CE552B99A7C900F2F2CA /* NetworkManager.swift */; };
 		08A6CE5A2B99A83C00F2F2CA /* NetworkManagable.swift in Sources */ = {isa = PBXBuildFile; fileRef = 08A6CE592B99A83C00F2F2CA /* NetworkManagable.swift */; };
 		08A6CE5D2B99C6CB00F2F2CA /* BoxOfficeDisplayModel.swift in Sources */ = {isa = PBXBuildFile; fileRef = 08A6CE5C2B99C6CB00F2F2CA /* BoxOfficeDisplayModel.swift */; };
 		08A6CE6E2B9AA76500F2F2CA /* BoxOfficeCell.swift in Sources */ = {isa = PBXBuildFile; fileRef = 08A6CE6D2B9AA76500F2F2CA /* BoxOfficeCell.swift */; };
 		08A6CE702B9AA9F000F2F2CA /* SynchronizedLockPropertyWrapper.swift in Sources */ = {isa = PBXBuildFile; fileRef = 08A6CE6F2B9AA9EF00F2F2CA /* SynchronizedLockPropertyWrapper.swift */; };
 		08A6CE732B9AAA4E00F2F2CA /* ViewControllerExtension.swift in Sources */ = {isa = PBXBuildFile; fileRef = 08A6CE722B9AAA4E00F2F2CA /* ViewControllerExtension.swift */; };
 		08AB8E8F2B7F479D00564AC5 /* KeyEnvironmentHandler.swift in Sources */ = {isa = PBXBuildFile; fileRef = 08AB8E8E2B7F479D00564AC5 /* KeyEnvironmentHandler.swift */; };
+		08B753A02BA82C84005BCF86 /* DEBUG-Keys.plist in Resources */ = {isa = PBXBuildFile; fileRef = 08B7539E2BA82C84005BCF86 /* DEBUG-Keys.plist */; };
 		08DCFED72B7C5722002E22EA /* BoxOfficeSample.json in Resources */ = {isa = PBXBuildFile; fileRef = 08DCFED62B7C5722002E22EA /* BoxOfficeSample.json */; };
 		08DCFEDF2B7C59D7002E22EA /* NetworkSessionTests.swift in Sources */ = {isa = PBXBuildFile; fileRef = 08DCFEDE2B7C59D7002E22EA /* NetworkSessionTests.swift */; };
 		63DF20EF2970E1A0005DF7D1 /* AppDelegate.swift in Sources */ = {isa = PBXBuildFile; fileRef = 63DF20EE2970E1A0005DF7D1 /* AppDelegate.swift */; };
@@ -74,14 +74,14 @@
 		0827984B2B88519900ACC723 /* MovieDetailInfo.swift */ = {isa = PBXFileReference; lastKnownFileType = sourcecode.swift; path = MovieDetailInfo.swift; sourceTree = "<group>"; };
 		0864FC622B9F2EE500CE0725 /* APIHostType.swift */ = {isa = PBXFileReference; lastKnownFileType = sourcecode.swift; path = APIHostType.swift; sourceTree = "<group>"; };
 		0864FC642B9F318000CE0725 /* ViewControllerFactoryProtocol.swift */ = {isa = PBXFileReference; lastKnownFileType = sourcecode.swift; path = ViewControllerFactoryProtocol.swift; sourceTree = "<group>"; };
-		0887A4FE2BA18B8700B69306 /* DEBUG-Keys.plist */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = text.plist.xml; path = "DEBUG-Keys.plist"; sourceTree = "<group>"; };
 		08A6CE552B99A7C900F2F2CA /* NetworkManager.swift */ = {isa = PBXFileReference; lastKnownFileType = sourcecode.swift; path = NetworkManager.swift; sourceTree = "<group>"; };
 		08A6CE592B99A83C00F2F2CA /* NetworkManagable.swift */ = {isa = PBXFileReference; lastKnownFileType = sourcecode.swift; path = NetworkManagable.swift; sourceTree = "<group>"; };
 		08A6CE5C2B99C6CB00F2F2CA /* BoxOfficeDisplayModel.swift */ = {isa = PBXFileReference; lastKnownFileType = sourcecode.swift; path = BoxOfficeDisplayModel.swift; sourceTree = "<group>"; };
 		08A6CE6D2B9AA76500F2F2CA /* BoxOfficeCell.swift */ = {isa = PBXFileReference; lastKnownFileType = sourcecode.swift; path = BoxOfficeCell.swift; sourceTree = "<group>"; };
 		08A6CE6F2B9AA9EF00F2F2CA /* SynchronizedLockPropertyWrapper.swift */ = {isa = PBXFileReference; lastKnownFileType = sourcecode.swift; path = SynchronizedLockPropertyWrapper.swift; sourceTree = "<group>"; };
 		08A6CE722B9AAA4E00F2F2CA /* ViewControllerExtension.swift */ = {isa = PBXFileReference; lastKnownFileType = sourcecode.swift; path = ViewControllerExtension.swift; sourceTree = "<group>"; };
 		08AB8E8E2B7F479D00564AC5 /* KeyEnvironmentHandler.swift */ = {isa = PBXFileReference; lastKnownFileType = sourcecode.swift; path = KeyEnvironmentHandler.swift; sourceTree = "<group>"; };
+		08B7539E2BA82C84005BCF86 /* DEBUG-Keys.plist */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = text.plist.xml; path = "DEBUG-Keys.plist"; sourceTree = "<group>"; };
 		08DCFED62B7C5722002E22EA /* BoxOfficeSample.json */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = text.json; path = BoxOfficeSample.json; sourceTree = "<group>"; };
 		08DCFEDC2B7C59D7002E22EA /* BoxOfficeUnitTests.xctest */ = {isa = PBXFileReference; explicitFileType = wrapper.cfbundle; includeInIndex = 0; path = BoxOfficeUnitTests.xctest; sourceTree = BUILT_PRODUCTS_DIR; };
 		08DCFEDE2B7C59D7002E22EA /* NetworkSessionTests.swift */ = {isa = PBXFileReference; lastKnownFileType = sourcecode.swift; path = NetworkSessionTests.swift; sourceTree = "<group>"; };
@@ -147,14 +147,6 @@
 			path = Common;
 			sourceTree = "<group>";
 		};
-		0887A4FD2BA18B8700B69306 /* Private */ = {
-			isa = PBXGroup;
-			children = (
-				0887A4FE2BA18B8700B69306 /* DEBUG-Keys.plist */,
-			);
-			path = Private;
-			sourceTree = "<group>";
-		};
 		08A6CE542B99A7BE00F2F2CA /* NetworkManager */ = {
 			isa = PBXGroup;
 			children = (
@@ -252,6 +244,14 @@
 			path = Resource;
 			sourceTree = "<group>";
 		};
+		08B7539F2BA82C84005BCF86 /* Private */ = {
+			isa = PBXGroup;
+			children = (
+				08B7539E2BA82C84005BCF86 /* DEBUG-Keys.plist */,
+			);
+			path = Private;
+			sourceTree = "<group>";
+		};
 		08DCFEDD2B7C59D7002E22EA /* BoxOfficeUnitTests */ = {
 			isa = PBXGroup;
 			children = (
@@ -287,8 +287,8 @@
 				C76965DC2B86E66500EF8F87 /* Presentation */,
 				C76965DD2B86E68B00EF8F87 /* Domain */,
 				C76965DE2B86E69900EF8F87 /* Data */,
+				08B7539F2BA82C84005BCF86 /* Private */,
 				082798482B884F8B00ACC723 /* Common */,
-				0887A4FD2BA18B8700B69306 /* Private */,
 				08AB8E7D2B7F288500564AC5 /* Resource */,
 			);
 			path = BoxOffice;
@@ -495,7 +495,7 @@
 			files = (
 				63DF20FB2970E1A1005DF7D1 /* LaunchScreen.storyboard in Resources */,
 				63DF20F82970E1A1005DF7D1 /* Assets.xcassets in Resources */,
-				0887A4FF2BA18B8800B69306 /* DEBUG-Keys.plist in Resources */,
+				08B753A02BA82C84005BCF86 /* DEBUG-Keys.plist in Resources */,
 				08DCFED72B7C5722002E22EA /* BoxOfficeSample.json in Resources */,
 			);
 			runOnlyForDeploymentPostprocessing = 0;

diff --git a/BoxOffice/Presentation/Controller/BoxOfficeViewController.swift b/BoxOffice/Presentation/Controller/BoxOfficeViewController.swift
@@ -26,6 +26,13 @@ final class BoxOfficeViewController: UIViewController {
 
 // MARK: - 생명주기
 extension BoxOfficeViewController {
+
+    override func loadView() {
+        self.boxOfficeCollectionView = BoxOfficeCollectionView(frame: .zero)
+        self.view = boxOfficeCollectionView
+
+    }
+
     override func viewDidLoad() {
         super.viewDidLoad()
         setupUI()
@@ -37,7 +44,6 @@ extension BoxOfficeViewController {
 // MARK: - Setup UI
 private extension BoxOfficeViewController {
     func setupUI() {
-        setupBoxOfficeView()
         configureCellRegistration()
         configureNavigationBar()
         setupRefreshControl()
@@ -47,23 +53,6 @@ private extension BoxOfficeViewController {
         navigationItem.title = Date().formattedDate(withFormat: "YYYY-MM-dd")
     }
 
-    // 커스텀 뷰 설정
-    func setupBoxOfficeView() {
-        boxOfficeCollectionView = BoxOfficeCollectionView(frame: .zero)
-        view.backgroundColor = boxOfficeCollectionView.backgroundColor
-        view.addSubview(boxOfficeCollectionView)
-        boxOfficeCollectionView.translatesAutoresizingMaskIntoConstraints = false
-
-        NSLayoutConstraint.activate([
-            boxOfficeCollectionView.leadingAnchor.constraint(equalTo: view.safeAreaLayoutGuide.leadingAnchor),
-            boxOfficeCollectionView.trailingAnchor.constraint(equalTo: view.safeAreaLayoutGuide.trailingAnchor),
-            boxOfficeCollectionView.bottomAnchor.constraint(equalTo: view.safeAreaLayoutGuide.bottomAnchor),
-            boxOfficeCollectionView.topAnchor.constraint(equalTo: view.safeAreaLayoutGuide.topAnchor)
-        ])
-
-        configureCellRegistration()
-    }
-
     // 셀 등록 설정 메서드
     func configureCellRegistration() {
         cellRegistration = UICollectionView.CellRegistration<BoxOfficeCell, BoxOfficeDisplayModel> { (cell, indexPath, movie) in