Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for Privacy Manifest #48

Merged
merged 4 commits into from
Apr 9, 2024
Merged

Support for Privacy Manifest #48

merged 4 commits into from
Apr 9, 2024

Conversation

CH3COOH
Copy link
Contributor

@CH3COOH CH3COOH commented Feb 22, 2024

Sorry. I can only use simple English. I use machine translation.

SwiftRater is using UserDefaults. I thought Privacy Manifest support was needed.

This Pull Request fixed the following items:

  • Add PrivacyInfo.xcprivacy when installed from CocoaPods
  • Add PrivacyInfo.xcprivacy when installed from Carthage
  • Add PrivacyInfo.xcprivacy when installed from Swift PM

ref: #47


Original Text:
SwiftRaterでは、アプリの起動回数など各種データを保持するためにUserDefaultsを利用しており、Privacy Manifest対応が必要だと考えています。このPull Requestでは以下の項目に対応しました。

  • CocoaPodsからインストールした場合、PrivacyInfo.xcprivacy が追加されるようにした
  • Carthageからインストールした場合、PrivacyInfo.xcprivacy が追加されるようにした
  • Swift PMからインストールした場合、PrivacyInfo.xcprivacy が追加されるようにした

@Adobels
Copy link

Adobels commented Apr 8, 2024

@takecian, I wanted to highlight the significance of this PR, especially for users relying on your framework. There's a potential risk of App Store rejection due to your framework's use of the UserDefaults API. It's crucial that you thoroughly justify its usage.

@takecian takecian merged commit 287b6b3 into takecian:master Apr 9, 2024
1 check passed
@takecian
Copy link
Owner

takecian commented Apr 9, 2024

@CH3COOH ありがとうございます!

@Adobels I will publish a new version soon 🙇

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants