Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR proposes using
ko
to build the container image, instead ofdocker build
.ko
generates an SBOM and attaches it to the image, seecosign download sbom ghcr.io/imjasonh/golink
ko
doesn't require you to maintain a Dockerfile, justko build
and get an image.ko
doesn't require any container runtime to build. Sincego build
is assumed not to have deleterious side effects, there's no real benefit to running it in a container; you can stop running Docker on your development machine.ko
supports multi-platform builds easily. Add--platform=linux/amd64,linux/arm64
, or just--platform=all
, to build for all platforms supported by your base image (currently 8 platforms).ko
builds images more reproducibly thandocker build
, which can lead to faster rebuilds and less registry storage.This also changes the image to not set the
--sqlitedb
or--verbose
flags by default anymore, and instead only recommend them at (production-)runtime.I've built this in my fork, see the Action run here: https://github.com/imjasonh/golink/actions/runs/3462861488, and the image it produced at
ghcr.io/imjasonh/golink
.