Add support for SOCKS5 proxy when fetching URL previews #616
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit adds simple support for using Go's x/net/proxy package to optionally pass all URL preview traffic through a configured SOCKS5 proxy. This allows easy segmentation of the normal Matrix traffic from URL preview traffic, or the use of a proxy to access the wider internet, without affecting connections between MMR and the homeserver.
Hopefully, as not much code was adjusted, this is simple enough to maintain that it wouldn't cause issues despite being a bit out of scope.