Add tracking for session_track_state_change and session_track_system_… #4159
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…variables Add tracking for 2 new variables: session_track_state_change and session_track_system_variables. If a client tries to set these variables explicitly, the request from the client will be ignored. Also, add a new ProxySQL MySQL variable (mysql-enable_session_state_trackers) that, if enabled, the 2 MySQL variables will be automatically set into each MySQL client connection. ProxySQL will try to set these variables on backend connections and will track if the SET on backend failed or succeeded.
Move it from MySQL_Session::handler() to MySQL_Thread::create_new_session_and_client_data_stream(). This way, we ensure the code is always executed when a client connects to ProxySQL.
MySQL_Thread::create_new_session_and_client_data_stream() to MySQL_Session::get_pkts_from_client(). Otherwise, session track variables state is lost when changing user.
Create a helper function to set the variables an use it after the creation of the client connection and after the reset of the client connection.
Checks whether session track variables have been configured properly.
|
retest this please |
1 similar comment
|
retest this please |
|
Closing because included in #4164 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…variables
Add tracking for 2 new variables: session_track_state_change and session_track_system_variables. If a client tries to set these variables explicitly, the request from the client will be ignored.
Also, add a new ProxySQL MySQL variable
(mysql-enable_session_state_trackers) that, if enabled, the 2 MySQL variables will be automatically set into each MySQL client connection. ProxySQL will try to set these variables on backend connections and will track if the SET on backend failed or succeeded.