Skip to content

Commit

Permalink
bug #2052 [Map] Re-add keyword "symfony-ux", to fix Symfony Flex `pac…
Browse files Browse the repository at this point in the history
…kage.json` resolving (Kocal)

This PR was merged into the 2.x branch.

Discussion
----------

[Map] Re-add keyword "symfony-ux", to fix Symfony Flex `package.json` resolving

| Q             | A
| ------------- | ---
| Bug fix?      | yes
| New feature?  | no <!-- please update src/**/CHANGELOG.md files -->
| Issues        | Fix #... <!-- prefix each issue number with "Fix #", no need to create an issue if none exist, explain below instead -->
| License       | MIT

<!--
Replace this notice by a description of your feature/bugfix.
This will help reviewers and should be a good start for the documentation.

Additionally (see https://symfony.com/releases):
 - Always add tests and ensure they pass.
 - For new features, provide some code snippets to help understand usage.
 - Features and deprecations must be submitted against branch main.
 - Changelog entry should follow https://symfony.com/doc/current/contributing/code/conventions.html#writing-a-changelog-entry
 - Never break backward compatibility (see https://symfony.com/bc).
-->

In #1937 I was asked to remove the keyword `symfony-ux` in favor `symfony` and `ux`, but it looks like it break Symfony Flex behaviour to resolve the package's `package.json`: https://github.com/symfony/flex/blob/2.x/src/PackageJsonSynchronizer.php#L372

No `importmap.php` nor `assets/controllers.json` were updated when installing UX Map bridges :(

I'm adding back this keyword and removing the other ones. Sorry for the inconvenience 🙏

Commits
-------

e417b4b [Map] Re-add keyword "symfony-ux", to fix Symfony Flex behaviour (importmap, controllers...)
  • Loading branch information
kbond committed Aug 13, 2024
2 parents 9e6920d + e417b4b commit d930b2e
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 2 deletions.
2 changes: 1 addition & 1 deletion src/Map/src/Bridge/Google/composer.json
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@
"name": "symfony/ux-google-map",
"type": "symfony-ux-map-bridge",
"description": "Symfony UX Map GoogleMaps Bridge",
"keywords": ["google-maps", "map", "symfony", "ux"],
"keywords": ["symfony-ux", "google-maps", "map"],
"homepage": "https://symfony.com",
"license": "MIT",
"authors": [
Expand Down
2 changes: 1 addition & 1 deletion src/Map/src/Bridge/Leaflet/composer.json
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@
"name": "symfony/ux-leaflet-map",
"type": "symfony-ux-map-bridge",
"description": "Symfony UX Map Leaflet Bridge",
"keywords": ["leaflet", "map", "symfony", "ux"],
"keywords": ["symfony-ux", "leaflet", "map"],
"homepage": "https://symfony.com",
"license": "MIT",
"authors": [
Expand Down

0 comments on commit d930b2e

Please sign in to comment.