Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update docker image for Mailcatcher #1279

Merged
merged 1 commit into from
Jan 10, 2024

Conversation

ker0x
Copy link
Contributor

@ker0x ker0x commented Jan 9, 2024

Q A
License MIT
Doc issue/PR -

This PR replace the unmaintained schickling image with the official Mailcatcher image

@symfony-recipes-bot symfony-recipes-bot enabled auto-merge (squash) January 9, 2024 04:30
Copy link

github-actions bot commented Jan 9, 2024

Thanks for the PR 😍

How to test these changes in your application

  1. Define the SYMFONY_ENDPOINT environment variable:

    # On Unix-like (BSD, Linux and macOS)
    export SYMFONY_ENDPOINT=https://raw.githubusercontent.com/symfony/recipes/flex/pull-1279/index.json
    # On Windows
    SET SYMFONY_ENDPOINT=https://raw.githubusercontent.com/symfony/recipes/flex/pull-1279/index.json
  2. Install the package(s) related to this recipe:

    composer req 'symfony/flex:^1.16'
    composer req 'symfony/mailer:^4.3'
  3. Don't forget to unset the SYMFONY_ENDPOINT environment variable when done:

    # On Unix-like (BSD, Linux and macOS)
    unset SYMFONY_ENDPOINT
    # On Windows
    SET SYMFONY_ENDPOINT=

Diff between recipe versions

In order to help with the review stage, I'm in charge of computing the diff between the various versions of patched recipes.
I'm going keep this comment up to date with any updates of the attached patch.

@ker0x
Copy link
Contributor Author

ker0x commented Jan 9, 2024

Another possibility would be to replace Mailcatcher with Mailpit, which offers many more features and a much lighter image (27 MB for Mailpit compared to 90 MB for Mailcatcher).

@symfony-recipes-bot symfony-recipes-bot merged commit 042b218 into symfony:main Jan 10, 2024
1 of 2 checks passed
@kbond
Copy link
Member

kbond commented Jan 10, 2024

Another possibility would be to replace Mailcatcher with Mailpit, which offers many more features and a much lighter image (27 MB for Mailpit compared to 90 MB for Mailcatcher).

Mailpit does look nice, perhaps discuss in another PR?

@ker0x ker0x deleted the feature/mailcatcher-image branch January 11, 2024 16:33
@ker0x
Copy link
Contributor Author

ker0x commented Jan 11, 2024

@kbond done, see #1281 😉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants