Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use app. prefix for parameters #1543

Merged
merged 1 commit into from
Dec 10, 2024
Merged

Use app. prefix for parameters #1543

merged 1 commit into from
Dec 10, 2024

Conversation

seb-jean
Copy link
Contributor

@seb-jean seb-jean commented Dec 8, 2024

I changed the locale setting to put the app. prefix in order to follow best practices.

https://symfony.com/doc/current/best_practices.html#use-short-and-prefixed-parameter-names :

Consider using app. as the prefix of your parameters to avoid collisions with Symfony and third-party bundles/libraries parameters. Then, use just one or two words to describe the purpose of the parameter

@javiereguiluz
Copy link
Member

Yes, let's follow our own best practices 🙏

Thanks @seb-jean!

@javiereguiluz javiereguiluz merged commit 3277fc2 into symfony:main Dec 10, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants