-
Notifications
You must be signed in to change notification settings - Fork 24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Removed Contributors.txt #82
Conversation
I believe we can get rid of this - the rest of the Swiftlang repos are moving away from having a contributors list to just relying on things like GH's tools |
Sounds like a plan! |
@0xTim Actually, it seems like the license headers (both in this repo and NIO) still reference the Contributors.txt — should I update that to no longer reference one, or should we keep it in after all? |
c1e078a
to
3bc3360
Compare
If we can remove it let's try that |
3bc3360
to
1f7ad9c
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One query otherwise LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we need this file anymore?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This one is actually used by git for authors UI — figured I'd leave it in?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I was not aware! In that case, keep it
Updated contributors list.