Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removed Contributors.txt #82

Merged
merged 1 commit into from
Oct 15, 2024
Merged

Removed Contributors.txt #82

merged 1 commit into from
Oct 15, 2024

Conversation

dimitribouniol
Copy link
Collaborator

Updated contributors list.

@dimitribouniol dimitribouniol self-assigned this Sep 23, 2024
@0xTim
Copy link
Member

0xTim commented Sep 23, 2024

I believe we can get rid of this - the rest of the Swiftlang repos are moving away from having a contributors list to just relying on things like GH's tools

@dimitribouniol
Copy link
Collaborator Author

Sounds like a plan!

@dimitribouniol
Copy link
Collaborator Author

@0xTim Actually, it seems like the license headers (both in this repo and NIO) still reference the Contributors.txt — should I update that to no longer reference one, or should we keep it in after all?

@0xTim
Copy link
Member

0xTim commented Sep 23, 2024

If we can remove it let's try that

@dimitribouniol dimitribouniol changed the title Updated Contributors List Removed Contributors.tx Sep 24, 2024
@dimitribouniol dimitribouniol changed the title Removed Contributors.tx Removed Contributors.txt Sep 24, 2024
Copy link
Member

@0xTim 0xTim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One query otherwise LGTM

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we need this file anymore?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This one is actually used by git for authors UI — figured I'd leave it in?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was not aware! In that case, keep it

@dimitribouniol dimitribouniol merged commit 0f31a51 into main Oct 15, 2024
13 checks passed
@dimitribouniol dimitribouniol deleted the dimitri/contributors branch October 15, 2024 20:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants