Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add swap metric to fly-apps dashboard #7

Open
wants to merge 2 commits into
base: fly-app-metrics
Choose a base branch
from

Conversation

shortdiv
Copy link

@shortdiv shortdiv commented Jun 9, 2023

Adding a swap metric to fly apps dashboard so we can link it to the ui

Related to https://github.com/superfly/ui-ex/pull/1020

@shortdiv shortdiv requested a review from wjordan June 9, 2023 15:59
@wjordan
Copy link

wjordan commented Jun 9, 2023

We already display swap in the Memory - Detailed panel on the Fly Instance dashboard. It uses a matcher with a regex on Swap.* to apply a transform to the negative Y axis so it can be viewed alongside normal memory usage. (This is similar to how it's displayed in the Node Exporter Full dashboard).

I could see adding swap in a similar way on the negative Y axis to the "Memory Utilization" panel in the Fly App dashboard, perhaps with a >0 on the query so the time series doesn't show up when swap isn't enabled. I think a separate swap-only panel like is a bit more noisy and would be inconsistent with the existing swap metrics in the Fly Instance memory panel.

@shortdiv
Copy link
Author

shortdiv commented Jun 9, 2023

I think I understood what you meant, updated!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants