Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[AUTOMATIONS-CONTRACT] Extended Vesting Scheduler Tests (no unsigned commits) #2002

Merged
merged 8 commits into from
Sep 17, 2024

Conversation

kasparkallas
Copy link
Contributor

Continuation of: #1994

@kasparkallas kasparkallas requested a review from a team as a code owner August 8, 2024 11:25
Copy link
Contributor

@hellwolf hellwolf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I noticed some tests failing. I suspect some flaky fuzzing tests. I will look into it when I have time.

Copy link
Contributor

@0xPilou 0xPilou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The stateful fuzz test seem to fail on some occassion.
Also, the stateful fuzz test does not cover claimable schedules.
Do you want me to add this ?

auto-merge was automatically disabled September 17, 2024 11:34

Merge commits are not allowed on this repository

@kasparkallas kasparkallas merged commit a7f5aef into dev Sep 17, 2024
13 checks passed
@kasparkallas kasparkallas deleted the 2024-08-08-additional-vesting-scheduler-tests branch September 17, 2024 11:41
Copy link

XKCD Comic Relif

Link: https://xkcd.com/2002
https://xkcd.com/2002

@kasparkallas
Copy link
Contributor Author

After this PR, this is the test coverage output of forge coverage:

| File                                                                                                  | % Lines           | % Statements       | % Branches        | % Funcs           |
|-------------------------------------------------------------------------------------------------------|-------------------|--------------------|-------------------|-------------------|
| packages/automation-contracts/scheduler/contracts/VestingSchedulerV2.sol                              | 98.16% (160/163)  | 98.81% (249/252)   | 85.00% (68/80)    | 100.00% (30/30)   |

The lack of complete 100% coverage can be explained by having guard clauses for readability and defensive programming that never actually get hit.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants