-
Notifications
You must be signed in to change notification settings - Fork 238
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[WORKFLOW] use dev as release draft branch trigger #1498
Conversation
Are we missing anything obvious? |
Incremental improvementalist inside me is screaming for a shared utility shell script that does the following while are at it, if you hold on, I could take a stab at it too:
|
Nothing other than making the utility shell script shared so we reduce some duplication.
pushed a file and giving this a try in a workflow run right now cc @hellwolf |
Consider to use the new script for auto release of trivial package such as metadata, see #1366 (comment) |
- move all workflow files in - next step: - try reusable workflow for the common steps
📦 PR PackagesInstall this PR (you need to setup Github packages): yarn add @superfluid-finance/ethereum-contracts@PR1498
yarn add @superfluid-finance/sdk-core@PR1498
yarn add @superfluid-finance/sdk-redux@PR1498 Click to learn how to use Github packagesTo use the Github package registry, create a token with "read:packages" permission. See Creating a personal access token for help. Next add these lines to your
|
.github/workflows/cd.sdk-redux-stable.create-release-drafts.yml
Outdated
Show resolved
Hide resolved
Codecov ReportPatch coverage has no change and project coverage change:
Additional details and impacted files@@ Coverage Diff @@
## dev #1498 +/- ##
==========================================
+ Coverage 87.33% 95.93% +8.60%
==========================================
Files 91 41 -50
Lines 4389 2139 -2250
Branches 184 0 -184
==========================================
- Hits 3833 2052 -1781
+ Misses 512 87 -425
+ Partials 44 0 -44
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
- add metadata release + publish in create-release-drafts - add LICENSE to metadata - update monorepo README.md
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ggg
XKCD Comic RelifLink: https://xkcd.com/1498 |
No description provided.