Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WORKFLOW] use dev as release draft branch trigger #1498

Merged
merged 11 commits into from
Jul 12, 2023

Conversation

0xdavinchee
Copy link
Contributor

No description provided.

@hellwolf
Copy link
Contributor

Are we missing anything obvious?

@hellwolf
Copy link
Contributor

Incremental improvementalist inside me is screaming for a shared utility shell script that does the following while are at it, if you hold on, I could take a stab at it too:

          # sdk-redux
          PUBLISHED_SDK_REDUX_VERSION=$(npm show @superfluid-finance/sdk-redux@latest version)
          NEW_SDK_REDUX_VERSION=$(jq -r .version packages/sdk-redux/package.json)
          if [ "$PUBLISHED_SDK_REDUX_VERSION" != "$NEW_SDK_REDUX_VERSION" ];then
            echo "PUBLISHED_SDK_REDUX_VERSION=1" >> "$GITHUB_ENV"
            echo "sdk-redux changed: $PUBLISHED_SDK_REDUX_VERSION -> $NEW_SDK_REDUX_VERSION"
          else
            echo sdk-redux unchanged: "$PUBLISHED_SDK_REDUX_VERSION"
          fi

          echo "NEW_SDK_REDUX_VERSION=$NEW_SDK_REDUX_VERSION" >> "$GITHUB_OUTPUT"

@0xdavinchee
Copy link
Contributor Author

Are we missing anything obvious?

Nothing other than making the utility shell script shared so we reduce some duplication.

Incremental improvementalist inside me is screaming for a shared utility shell script that does the following while are at it, if you hold on, I could take a stab at it too:

          # sdk-redux
          PUBLISHED_SDK_REDUX_VERSION=$(npm show @superfluid-finance/sdk-redux@latest version)
          NEW_SDK_REDUX_VERSION=$(jq -r .version packages/sdk-redux/package.json)
          if [ "$PUBLISHED_SDK_REDUX_VERSION" != "$NEW_SDK_REDUX_VERSION" ];then
            echo "PUBLISHED_SDK_REDUX_VERSION=1" >> "$GITHUB_ENV"
            echo "sdk-redux changed: $PUBLISHED_SDK_REDUX_VERSION -> $NEW_SDK_REDUX_VERSION"
          else
            echo sdk-redux unchanged: "$PUBLISHED_SDK_REDUX_VERSION"
          fi

          echo "NEW_SDK_REDUX_VERSION=$NEW_SDK_REDUX_VERSION" >> "$GITHUB_OUTPUT"

pushed a file and giving this a try in a workflow run right now

cc @hellwolf

@hellwolf
Copy link
Contributor

Consider to use the new script for auto release of trivial package such as metadata, see #1366 (comment)

- move all workflow files in
- next step:
  - try reusable workflow for the common steps
@github-actions
Copy link

📦 PR Packages

Install this PR (you need to setup Github packages):

yarn add @superfluid-finance/ethereum-contracts@PR1498
yarn add @superfluid-finance/sdk-core@PR1498
yarn add @superfluid-finance/sdk-redux@PR1498
:octocat: Click to learn how to use Github packages

To use the Github package registry, create a token with "read:packages" permission. See Creating a personal access token for help.

Next add these lines to your .npmrc file, replacing TOKEN with your personal access token. See Installing a package from Github if you get stuck.

@superfluid-finance:registry=https://npm.pkg.github.com
//npm.pkg.github.com/:_authToken=TOKEN

- remove sdk-redux create release draft
- use template release notes file
@codecov
Copy link

codecov bot commented Jul 11, 2023

Codecov Report

Patch coverage has no change and project coverage change: +8.60 🎉

Comparison is base (78a1174) 87.33% compared to head (e622bc4) 95.93%.

❗ Current head e622bc4 differs from pull request most recent head feb5753. Consider uploading reports for the commit feb5753 to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##              dev    #1498      +/-   ##
==========================================
+ Coverage   87.33%   95.93%   +8.60%     
==========================================
  Files          91       41      -50     
  Lines        4389     2139    -2250     
  Branches      184        0     -184     
==========================================
- Hits         3833     2052    -1781     
+ Misses        512       87     -425     
+ Partials       44        0      -44     
Flag Coverage Δ
ethereum-contracts 95.93% <ø> (ø)
sdk-core ?

Flags with carried forward coverage won't be shown. Click here to find out more.

see 50 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@0xdavinchee 0xdavinchee linked an issue Jul 11, 2023 that may be closed by this pull request
- add metadata release + publish in create-release-drafts
- add LICENSE to metadata
- update monorepo README.md
@0xdavinchee 0xdavinchee requested a review from a team as a code owner July 11, 2023 13:53
Copy link
Contributor

@hellwolf hellwolf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ggg

@0xdavinchee 0xdavinchee merged commit 9c0cd0f into dev Jul 12, 2023
16 checks passed
@0xdavinchee 0xdavinchee deleted the dev-on-push-release-draft-cd branch July 12, 2023 08:11
@github-actions
Copy link

XKCD Comic Relif

Link: https://xkcd.com/1498
https://xkcd.com/1498

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[WORKFLOW] Refactor release workflow files
2 participants