Remove pydantic from config #1621
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
blythed
reviewed
Dec 30, 2023
superduperdb/base/logger.py
Outdated
| @@ -14,6 +14,9 @@ | |||
| __all__ = ('Logging',) | |||
|
|
|||
|
|
|||
| breakpoint() | |||
blythed
reviewed
Dec 30, 2023
| class BaseConfigJSONable(JSONable): | ||
| @dc.dataclass | ||
| class BaseConfigJSONable: | ||
| _lock: t.ClassVar[bool] = False |
There was a problem hiding this comment.
This is for locking the config after initialisation
kartik4949
force-pushed
the
fix/remove_pydantic_from_config
branch
from
cac4f3d
to
f330ef9
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1621 +/- ##
==========================================
+ Coverage 80.33% 80.64% +0.30%
==========================================
Files 95 111 +16
Lines 6602 7899 +1297
==========================================
+ Hits 5304 6370 +1066
- Misses 1298 1529 +231 ☔ View full report in Codecov by Sentry. |
blythed
approved these changes
Dec 30, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fix #1609
Related Issues
Checklist
make unit-testingandmake integration-testingsuccessfully?Additional Notes or Comments