Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Devcontainer support that will enable windows and all other vscode users including Mac to develop SuperDuperDB in a safe environment #1531

Closed

Conversation

fazlulkarimweb
Copy link
Collaborator

@fazlulkarimweb fazlulkarimweb commented Dec 12, 2023

A dev-container is essential for 61% of Windows developers and all other people who use Mac or Linux to create an environment where coding is seamless. Later the devcontainer can be converted into a remote environment where people can code remotely. Langchain, Mindsdb all have devcontainers.

But for SuperDuperDB, this is a very tricky task as mentioned here:
https://github.com/SuperDuperDB/superduperdb/issues/715#issuecomment-1733711946

I used it for my tasks since the last month. But, I will further test it in my free time.

The benefits of this are one - All development will be seamless across the machines & OS! And make the environment for developing with SuperDuperDB, super easy.

@codecov-commenter
Copy link

codecov-commenter commented Dec 12, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (34830a7) 80.33% compared to head (20b6b06) 80.64%.
Report is 1335 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1531      +/-   ##
==========================================
+ Coverage   80.33%   80.64%   +0.30%     
==========================================
  Files          95      111      +16     
  Lines        6602     7884    +1282     
==========================================
+ Hits         5304     6358    +1054     
- Misses       1298     1526     +228     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@fazlulkarimweb fazlulkarimweb marked this pull request as ready for review December 15, 2023 20:39
@fazlulkarimweb
Copy link
Collaborator Author

This is what devcontainer is: https://code.visualstudio.com/docs/devcontainers/containers

And later it can be converted into GitHub Codespace where people can code remotely:
https://docs.github.com/en/codespaces/setting-up-your-project-for-codespaces/adding-a-dev-container-configuration/introduction-to-dev-containers

I tried to use the same dockerfile from deploy but it's not possible. I can move this docker file to the folder called deploy for greater abstraction. But this dockerfile is needed.

@blythed
Copy link
Collaborator

blythed commented Jan 2, 2024

Nothing happening here, so closing.

@blythed blythed closed this Jan 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants