Remove redundant arguments from components using kw_only=True
#1495
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1495 +/- ##
==========================================
+ Coverage 80.33% 80.61% +0.27%
==========================================
Files 95 104 +9
Lines 6602 7306 +704
==========================================
+ Hits 5304 5890 +586
- Misses 1298 1416 +118 ☔ View full report in Codecov by Sentry. |
kartik4949
reviewed
Dec 7, 2023
jieguangzhou
reviewed
Dec 8, 2023
Comment on lines
+28
to
+31
| def __post_init__(self) -> None: | ||
| # set version in `__post_init__` so that is | ||
| # cannot be set in `__init__` and is always set | ||
| self.version: t.Optional[int] = None |
There was a problem hiding this comment.
Add self.type_id = self.__class__.__name__ in the post_init
There was a problem hiding this comment.
I think we need to discuss this -- can be done later. (The code is old, just moved around a bit, creating this diff.)
superduperdb/components/model.py
Outdated
Comment on lines
462
to
471
| artifact_attributes: t.ClassVar[t.Sequence[str]] = [ | ||
| 'object', | ||
| 'preprocess', | ||
| 'postprocess', | ||
| ] |
There was a problem hiding this comment.
We should avoid using mutable objects in such places
blythed
force-pushed
the
feature/non-redundant-parameters
branch
from
d28759e
to
8c0687e
Compare
blythed
force-pushed
the
feature/non-redundant-parameters
branch
from
8c0687e
to
edcec7e
Compare
|
Comments addressed, will merge. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current
Componentclasses have very redundant and bloated signatures. This is due to thefact that we were trying to respect the ordering which
@dataclassforces. By addingthe
@dataclass(kw_only=True)decorator, we are able to avoid this mess, allowing for a significantcleaning up of signatures.
In the process of doing this, it was necessary to finally deal with the fact that
Component.versionshould neverbe set via
__init__.