Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

separate accounts for user and test #1438

Closed

Conversation

fnikolai
Copy link
Collaborator

@fnikolai fnikolai commented Dec 1, 2023

Description

Related Issues

Checklist

  • Is this code covered by new or existing unit tests or integration tests?
  • Did you run make test successfully?
  • Do new classes, functions, methods and parameters all have docstrings?
  • Were existing docstrings updated, if necessary?
  • Was external documentation updated, if necessary?

Additional Notes or Comments

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (34830a7) 80.33% compared to head (236e6d2) 68.99%.
Report is 159 commits behind head on main.

Additional details and impacted files
@@             Coverage Diff             @@
##             main    #1438       +/-   ##
===========================================
- Coverage   80.33%   68.99%   -11.35%     
===========================================
  Files          95      103        +8     
  Lines        6602     7169      +567     
===========================================
- Hits         5304     4946      -358     
- Misses       1298     2223      +925     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@blythed
Copy link
Collaborator

blythed commented Dec 2, 2023

Subset of features added to #1427 so closing.

@blythed blythed closed this Dec 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants