Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix redundant exception logging #1419

Merged
merged 1 commit into from
Nov 29, 2023

Conversation

thejumpman2323
Copy link
Contributor

@thejumpman2323 thejumpman2323 commented Nov 29, 2023

Description

This pr fixes the redundant logging exception happing in the traceback.

Related Issues

Checklist

  • Is this code covered by new or existing unit tests or integration tests?
  • Did you run make test successfully?
  • Do new classes, functions, methods and parameters all have docstrings?
  • Were existing docstrings updated, if necessary?
  • Was external documentation updated, if necessary?

Additional Notes or Comments

@thejumpman2323 thejumpman2323 self-assigned this Nov 29, 2023
@fnikolai fnikolai self-requested a review November 29, 2023 10:30
@codecov-commenter
Copy link

Codecov Report

Attention: 11 lines in your changes are missing coverage. Please review.

Comparison is base (34830a7) 80.33% compared to head (ec7f496) 79.57%.
Report is 135 commits behind head on main.

Files Patch % Lines
superduperdb/backends/base/compute.py 68.96% 9 Missing ⚠️
superduperdb/backends/base/artifact.py 80.00% 1 Missing ⚠️
superduperdb/backends/base/data_backend.py 80.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1419      +/-   ##
==========================================
- Coverage   80.33%   79.57%   -0.77%     
==========================================
  Files          95      103       +8     
  Lines        6602     7329     +727     
==========================================
+ Hits         5304     5832     +528     
- Misses       1298     1497     +199     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@fnikolai fnikolai merged commit 4661700 into superduper-io:main Nov 29, 2023
2 checks passed
@thejumpman2323 thejumpman2323 deleted the fix/exceptions branch November 29, 2023 11:01
fnikolai pushed a commit that referenced this pull request Dec 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants