Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix minor bug in transformers ext #1417

Merged
merged 2 commits into from
Nov 29, 2023

Conversation

thejumpman2323
Copy link
Contributor

@thejumpman2323 thejumpman2323 commented Nov 28, 2023

Description

Remove unnecessary preprocessing_kwargs as kwargs in self.pipeline

Related Issues

Checklist

  • Is this code covered by new or existing unit tests or integration tests?
  • Did you run make test successfully?
  • Do new classes, functions, methods and parameters all have docstrings?
  • Were existing docstrings updated, if necessary?
  • Was external documentation updated, if necessary?

Additional Notes or Comments

@codecov-commenter
Copy link

codecov-commenter commented Nov 28, 2023

Codecov Report

Attention: 34 lines in your changes are missing coverage. Please review.

Comparison is base (34830a7) 80.33% compared to head (29f0f85) 67.07%.
Report is 132 commits behind head on main.

Files Patch % Lines
superduperdb/backends/dask/compute.py 47.05% 18 Missing ⚠️
superduperdb/backends/base/compute.py 68.96% 9 Missing ⚠️
superduperdb/backends/base/query.py 85.71% 3 Missing ⚠️
superduperdb/backends/base/metadata.py 66.66% 2 Missing ⚠️
superduperdb/backends/base/artifact.py 66.66% 1 Missing ⚠️
superduperdb/backends/base/data_backend.py 66.66% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##             main    #1417       +/-   ##
===========================================
- Coverage   80.33%   67.07%   -13.27%     
===========================================
  Files          95      103        +8     
  Lines        6602     7283      +681     
===========================================
- Hits         5304     4885      -419     
- Misses       1298     2398     +1100     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@thejumpman2323 thejumpman2323 force-pushed the fix/minor_bug_in_transformer branch 2 times, most recently from d6f30ae to e60f3e6 Compare November 28, 2023 19:30
@blythed blythed merged commit 32a0395 into superduper-io:main Nov 29, 2023
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants