Skip to content

Commit

Permalink
Fix copy_vectors dependencies
Browse files Browse the repository at this point in the history
  • Loading branch information
blythed committed Jun 20, 2024
1 parent 2330ae0 commit d2a9326
Show file tree
Hide file tree
Showing 4 changed files with 7 additions and 3 deletions.
2 changes: 1 addition & 1 deletion CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,7 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
- Make output of `Document.encode()` a bit more minimalistic
- Increment minimum supported ibis version to 9.0.0
- Make database connections reconnection on token expiry
- Prototype cron job service
- Prototype the cron job service

#### New Features & Functionality

Expand Down
2 changes: 2 additions & 0 deletions superduperdb/base/datalayer.py
Original file line number Diff line number Diff line change
Expand Up @@ -910,6 +910,8 @@ def _apply(
if parent is not None:
self.metadata.create_parent_child(parent, object.uuid)

dependencies = [*[j.job_id for j in jobs], *dependencies] # type: ignore[list-item]

object.post_create(self)
self._add_component_to_cache(object)
these_jobs = object.schedule_jobs(self, dependencies=dependencies)
Expand Down
4 changes: 3 additions & 1 deletion superduperdb/misc/server.py
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@
from superduperdb.base import exceptions
from superduperdb.misc.auto_schema import DEFAULT_DATATYPE

primitives = (bool, str, int, float, type(None))
primitives = (bool, str, int, float, type(None), list)


@lru_cache(maxsize=None)
Expand Down Expand Up @@ -53,6 +53,8 @@ def _request_server(
if type == 'post':
if data is not None:
# TODO: Please use Document.encode with autoschema.
# TODO: This is too implicit and hard to read
# suggestion: add a parameter

if not isinstance(data, primitives):
data = _server_request_encoder(data)
Expand Down
2 changes: 1 addition & 1 deletion test/unittest/test_quality.py
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@
ALLOWABLE_DEFECTS = {
'cast': 9, # Try to keep this down
'noqa': 5, # This should never change
'type_ignore': 12, # This should only ever increase in obscure edge cases
'type_ignore': 13, # This should only ever increase in obscure edge cases
}


Expand Down

0 comments on commit d2a9326

Please sign in to comment.