Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Sign off field implementation in react #4272

Merged
merged 3 commits into from
Jun 28, 2023
Merged

Sign off field implementation in react #4272

merged 3 commits into from
Jun 28, 2023

Conversation

thecalcc
Copy link
Contributor

@thecalcc thecalcc commented Jun 23, 2023 •
edited
Loading

SDESK-6963

@tomaskikutis
Copy link
Member

  • comment on purpose of helper component
  • unused vars
  • cancel fn, abort controller
  • <span style={{border: '1px dotted blue'}}>, avatar
  • value template not needed
  • sign off mapping / NOT username

@tomaskikutis tomaskikutis changed the base branch from authoring-react-post-broadcasting to authoring-refactoring-post-big-merge June 28, 2023 08:50
@tomaskikutis tomaskikutis changed the base branch from authoring-refactoring-post-big-merge to authoring-react-post-broadcasting June 28, 2023 08:51
@thecalcc thecalcc merged commit cd1e1b2 into superdesk:authoring-react-post-broadcasting Jun 28, 2023
1 of 3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tomaskikutis tomaskikutis tomaskikutis approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@thecalcc @tomaskikutis